From: Ben Greear <greearb@candelatech.com>
To: NetDev <netdev@vger.kernel.org>
Cc: Patrick McHardy <kaber@trash.net>
Subject: Re: Routing tables associated with VLANs dissappear when parent ethX down/up
Date: Wed, 21 Nov 2007 11:51:43 -0800 [thread overview]
Message-ID: <47448C4F.3060107@candelatech.com> (raw)
In-Reply-To: <474387E4.7020802@candelatech.com>
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
For consideration, this patch seems to work for me. I'm not sure
why we ever listed to these events. I've only tested on a NIC that
doesn't support hw-accel at the moment..will test with e1000 later.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
[-- Attachment #2: vlan.patch --]
[-- Type: text/x-patch, Size: 823 bytes --]
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index c4209c8..acbf0ff 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -615,6 +615,11 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
}
break;
+#if 0
+ /* Don't propagate management state from base dev to VLANs. If you do this,
+ * then if you 'ifconfig eth0 down; ifconfig eth0 up', you also lose all the
+ * routes for eth0.* VLANs. --Ben
+ */
case NETDEV_DOWN:
/* Put all VLANs for this dev in the down state too. */
for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) {
@@ -644,6 +649,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
dev_change_flags(vlandev, flgs | IFF_UP);
}
break;
+#endif
case NETDEV_UNREGISTER:
/* Delete all VLANs for this dev. */
next prev parent reply other threads:[~2007-11-21 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 1:20 Routing tables associated with VLANs dissappear when parent ethX down/up Ben Greear
2007-11-21 19:51 ` Ben Greear [this message]
2007-11-21 20:00 ` Stephen Hemminger
2007-11-21 20:25 ` Patrick McHardy
2007-11-21 20:54 ` Ben Greear
2007-11-21 21:12 ` Patrick McHardy
2007-11-21 21:52 ` Ben Greear
2007-11-21 22:24 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47448C4F.3060107@candelatech.com \
--to=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).