From: Jeff Garzik <jgarzik@pobox.com>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] amd8111e: don't call napi_enable if configured w/o NAPI
Date: Fri, 23 Nov 2007 22:09:36 -0500 [thread overview]
Message-ID: <474795F0.1040600@pobox.com> (raw)
In-Reply-To: <20071121124007.GB3335@dwarf.suse.cz>
Jiri Bohac wrote:
> The amd8111e network driver was broken by
> bea3348eef27e6044b6161fd04c3152215f96411, which makes the driver
> call napi_enable() and napi_disable() even if the driver had been
> configured without CONFIG_AMD8111E_NAPI, and thus
> netif_napi_add() had not been called on initialization.
> This triggers a BUG in napi_enable().
>
> This patch fixes the problem. Please apply.
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
>
applied #upstream-fixes
would you consider creating and testing a patch that removed the
non-NAPI path completely?
prev parent reply other threads:[~2007-11-24 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 12:40 [PATCH] amd8111e: don't call napi_enable if configured w/o NAPI Jiri Bohac
2007-11-24 3:09 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474795F0.1040600@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).