* [PATCH] smc911x: Fix undefined CONFIG_ symbol warning
@ 2007-11-21 14:28 Peter Korsgaard
2007-11-24 3:09 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2007-11-21 14:28 UTC (permalink / raw)
To: netdev, jeff, super.firetwister
elif defined(CONFIG_*) should be used instead of elif CONFIG_*
so GCC doesn't give warnings about undefined symbols when the config
option is disabled.
---
drivers/net/smc911x.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
index 16a0edc..d04e4fa 100644
--- a/drivers/net/smc911x.h
+++ b/drivers/net/smc911x.h
@@ -37,7 +37,7 @@
#define SMC_USE_16BIT 0
#define SMC_USE_32BIT 1
#define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING
-#elif CONFIG_SH_MAGIC_PANEL_R2
+#elif defined(CONFIG_SH_MAGIC_PANEL_R2)
#define SMC_USE_SH_DMA 0
#define SMC_USE_16BIT 0
#define SMC_USE_32BIT 1
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] smc911x: Fix undefined CONFIG_ symbol warning
@ 2007-11-21 14:28 Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2007-11-21 14:28 UTC (permalink / raw)
To: netdev, jeff, super.firetwister
elif defined(CONFIG_*) should be used instead of elif CONFIG_*
so GCC doesn't give warnings about undefined symbols when the config
option is disabled.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
Sigh, forgot --signoff :/
drivers/net/smc911x.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
index 16a0edc..d04e4fa 100644
--- a/drivers/net/smc911x.h
+++ b/drivers/net/smc911x.h
@@ -37,7 +37,7 @@
#define SMC_USE_16BIT 0
#define SMC_USE_32BIT 1
#define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING
-#elif CONFIG_SH_MAGIC_PANEL_R2
+#elif defined(CONFIG_SH_MAGIC_PANEL_R2)
#define SMC_USE_SH_DMA 0
#define SMC_USE_16BIT 0
#define SMC_USE_32BIT 1
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] smc911x: Fix undefined CONFIG_ symbol warning
2007-11-21 14:28 [PATCH] smc911x: Fix undefined CONFIG_ symbol warning Peter Korsgaard
@ 2007-11-24 3:09 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-11-24 3:09 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: netdev, super.firetwister
Peter Korsgaard wrote:
> elif defined(CONFIG_*) should be used instead of elif CONFIG_*
> so GCC doesn't give warnings about undefined symbols when the config
> option is disabled.
> ---
> drivers/net/smc911x.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
> index 16a0edc..d04e4fa 100644
> --- a/drivers/net/smc911x.h
> +++ b/drivers/net/smc911x.h
> @@ -37,7 +37,7 @@
> #define SMC_USE_16BIT 0
> #define SMC_USE_32BIT 1
> #define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING
> -#elif CONFIG_SH_MAGIC_PANEL_R2
> +#elif defined(CONFIG_SH_MAGIC_PANEL_R2)
> #define SMC_USE_SH_DMA 0
> #define SMC_USE_16BIT 0
applied all three to #upstream-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-24 3:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 14:28 [PATCH] smc911x: Fix undefined CONFIG_ symbol warning Peter Korsgaard
2007-11-24 3:09 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-11-21 14:28 Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).