netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: e1000 driver problems
Date: Tue, 27 Nov 2007 10:23:00 -0800	[thread overview]
Message-ID: <474C6084.9000301@intel.com> (raw)
In-Reply-To: <20071127174456.GH4365@ics.muni.cz>

Lukas Hejtmanek wrote:
> On Tue, Nov 27, 2007 at 09:40:08AM -0800, Kok, Auke wrote:
>>> I'm afraid, I'm missing the point as you have stated that in-kernel drivers
>>> have problem with suspicious board hang...
>> my mistake, sorry for that confusion.
>>
>> the fake hangs on 82562/6 devices occur on 10mbit link only. You can check in the
>> code for a line that says:
>>
>> 	adapter->tx_timeout_factor = 8;
>>
>> change that number to 16 to cope with the problem on 10mbit link partners.
>> However this won't fix the issue on 100mbit partners and we need to
>> investigate that if that is the case.
> 
> 100mbit is the issue in my case.
> 

can you see if your problem goes away with this patch?

---
e1000: increase tx timeout factor for 100mbit speeds

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index b7c3070..2e46a15 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -2601,7 +2601,7 @@ e1000_watchdog(unsigned long data)
                        case SPEED_100:
                                txb2b = 0;
                                netdev->tx_queue_len = 100;
-                               /* maybe add some timeout factor ? */
+                               adapter->tx_timeout_factor = 4;
                                break;
                        }

  reply	other threads:[~2007-11-27 18:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061017205316.25914.qmail@web83109.mail.mud.yahoo.com>
     [not found] ` <45354850.6050900@intel.com>
     [not found]   ` <20071120143803.GA5638@ics.muni.cz>
     [not found]     ` <474B5610.4030800@intel.com>
     [not found]       ` <20071127150700.GB4365@ics.muni.cz>
     [not found]         ` <474C4A74.90705@intel.com>
     [not found]           ` <20071127173146.GG4365@ics.muni.cz>
2007-11-27 17:40             ` e1000 driver problems Kok, Auke
2007-11-27 17:44               ` Lukas Hejtmanek
2007-11-27 18:23                 ` Kok, Auke [this message]
2007-12-03  9:50                   ` Lukas Hejtmanek
2007-12-03 15:20                     ` Kok, Auke
2007-12-04 15:03                       ` Lukas Hejtmanek
2007-12-04 15:34                       ` Lukas Hejtmanek
2007-12-04 16:02                         ` Matt Mathis
2007-12-04 17:08                           ` Lukas Hejtmanek
2007-12-04 17:19                             ` Kok, Auke
2007-12-04 18:05                               ` Rick Jones
2007-12-04 19:59                               ` Lukas Hejtmanek
2007-12-04 20:38                                 ` Kok, Auke
2007-12-18 11:08                       ` Lukas Hejtmanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474C6084.9000301@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=xhejtman@ics.muni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).