From: Patrick McHardy <kaber@trash.net>
To: Ryousei Takano <takano-ryousei@aist.go.jp>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
dada1@cosmosbay.com, t.kudoh@aist.go.jp
Subject: Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module
Date: Wed, 28 Nov 2007 10:17:30 +0100 [thread overview]
Message-ID: <474D322A.9090207@trash.net> (raw)
In-Reply-To: <20071128.161905.109761213.takano@axe-inc.co.jp>
Ryousei Takano wrote:
> Hi Patrick,
>
>>>>> +struct tc_psp_qopt
>>>>> +{
>>>>> + __u32 defcls;
>>>>> + __u32 rate;
>>>>> +};
>>>> What unit is rate measured in?
>>>>
>>> 'rate' is the transmission rate in bytes per sec.
>>
>> So wouldn't it make sense to use u64 then for 10GBit networks?
>>
> I decided to use u32 after tc_ratespec.rate is u32.
> u32 is large enough for 10Gbit networks, but small for 40Gbit.
> I will use u64, because code becomes simple and consistent.
Right, I was thinking about bits per second :)
prev parent reply other threads:[~2007-11-28 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 15:50 [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module Ryousei Takano
2007-11-26 18:15 ` Patrick McHardy
2007-11-27 11:08 ` TAKANO Ryousei
2007-11-27 12:16 ` Patrick McHardy
2007-11-27 16:57 ` Ryousei Takano
2007-11-28 7:19 ` Ryousei Takano
2007-11-28 9:17 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D322A.9090207@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=t.kudoh@aist.go.jp \
--cc=takano-ryousei@aist.go.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).