* sock_valbool_flag is required by VMware
@ 2007-11-30 21:52 Jiri Slaby
2007-12-02 13:58 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2007-11-30 21:52 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: David S. Miller, netdev
Hi,
this commit:
[NET]: Move sock_valbool_flag to socket.c
The sock_valbool_flag() helper is used in setsockopt to
set or reset some flag on the sock. This helper is required
in the net/socket.c only, so move it there.
Besides, patch two places in sys_setsockopt() that repeat
this helper functionality manually.
Since this is not a bugfix, but a trivial cleanup, I
prepared this patch against net-2.6.25, but it also
applies (with a single offset) to the latest net-2.6.
breaks vmware module compilation, since it uses sock_valbool_flag(). Is this
their business (and they should use sock_set_flag/sock_reset_flag) or should
this be reverted?
thanks,
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: sock_valbool_flag is required by VMware
2007-11-30 21:52 sock_valbool_flag is required by VMware Jiri Slaby
@ 2007-12-02 13:58 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-12-02 13:58 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Pavel Emelyanov, David S. Miller, netdev
On Fri, Nov 30, 2007 at 10:52:22PM +0100, Jiri Slaby wrote:
> Hi,
>
> this commit:
> [NET]: Move sock_valbool_flag to socket.c
>
> The sock_valbool_flag() helper is used in setsockopt to
> set or reset some flag on the sock. This helper is required
> in the net/socket.c only, so move it there.
>
> Besides, patch two places in sys_setsockopt() that repeat
> this helper functionality manually.
>
> Since this is not a bugfix, but a trivial cleanup, I
> prepared this patch against net-2.6.25, but it also
> applies (with a single offset) to the latest net-2.6.
>
> breaks vmware module compilation, since it uses sock_valbool_flag(). Is this
> their business (and they should use sock_set_flag/sock_reset_flag) or should
> this be reverted?
It's their business, they should never have used it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-02 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-30 21:52 sock_valbool_flag is required by VMware Jiri Slaby
2007-12-02 13:58 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).