From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, Robert.Olsson@data.slu.se,
shemminger@linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH] e1000: Fix NAPI state bug when Rx complete
Date: Sat, 01 Dec 2007 16:34:31 -0500 [thread overview]
Message-ID: <4751D367.3030908@garzik.org> (raw)
In-Reply-To: <20071128002636.26015.28453.stgit@localhost.localdomain>
Auke Kok wrote:
> Don't exit polling when we have not yet used our budget, this causes
> the NAPI system to end up with a messed up poll list.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000/e1000_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index b7c3070..724f067 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -3926,7 +3926,7 @@ e1000_clean(struct napi_struct *napi, int budget)
> &work_done, budget);
>
> /* If no Tx and not enough Rx work done, exit the polling mode */
> - if ((!tx_cleaned && (work_done < budget)) ||
> + if ((!tx_cleaned && (work_done == 0)) ||
> !netif_running(poll_dev)) {
applied
prev parent reply other threads:[~2007-12-01 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 0:26 [PATCH] e1000: Fix NAPI state bug when Rx complete Auke Kok
2007-12-01 21:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4751D367.3030908@garzik.org \
--to=jeff@garzik.org \
--cc=Robert.Olsson@data.slu.se \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).