* [PATCH] e1000: Fix NAPI state bug when Rx complete
@ 2007-11-28 0:26 Auke Kok
2007-12-01 21:34 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Auke Kok @ 2007-11-28 0:26 UTC (permalink / raw)
To: jeff; +Cc: netdev, Robert.Olsson, shemminger, davem
Don't exit polling when we have not yet used our budget, this causes
the NAPI system to end up with a messed up poll list.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000/e1000_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index b7c3070..724f067 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -3926,7 +3926,7 @@ e1000_clean(struct napi_struct *napi, int budget)
&work_done, budget);
/* If no Tx and not enough Rx work done, exit the polling mode */
- if ((!tx_cleaned && (work_done < budget)) ||
+ if ((!tx_cleaned && (work_done == 0)) ||
!netif_running(poll_dev)) {
quit_polling:
if (likely(adapter->itr_setting & 3))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] e1000: Fix NAPI state bug when Rx complete
2007-11-28 0:26 [PATCH] e1000: Fix NAPI state bug when Rx complete Auke Kok
@ 2007-12-01 21:34 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-12-01 21:34 UTC (permalink / raw)
To: Auke Kok; +Cc: netdev, Robert.Olsson, shemminger, davem
Auke Kok wrote:
> Don't exit polling when we have not yet used our budget, this causes
> the NAPI system to end up with a messed up poll list.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000/e1000_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index b7c3070..724f067 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -3926,7 +3926,7 @@ e1000_clean(struct napi_struct *napi, int budget)
> &work_done, budget);
>
> /* If no Tx and not enough Rx work done, exit the polling mode */
> - if ((!tx_cleaned && (work_done < budget)) ||
> + if ((!tx_cleaned && (work_done == 0)) ||
> !netif_running(poll_dev)) {
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-01 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-28 0:26 [PATCH] e1000: Fix NAPI state bug when Rx complete Auke Kok
2007-12-01 21:34 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).