From: Pavel Emelyanov <xemul@openvz.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Netdev List <netdev@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH net-2.6.25 1/6][CORE] Remove unneeded ifdefs from sysctl_net_core.c
Date: Mon, 03 Dec 2007 11:57:53 +0300 [thread overview]
Message-ID: <4753C511.6090105@openvz.org> (raw)
In-Reply-To: <m1tzn13l72.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> Pavel Emelyanov <xemul@openvz.org> writes:
>
>> They include the whole file, but it is already compiled
>> out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target
>> in the Makefile.
>
> Pavel thanks for sending these patches. Might I ask
> for some level of acknowledgement when you rework one of
> my patches and send it off.
Sure. I though I've been doing exactly this thing. I've said
that unix ctls were from your tree and so on.
> I suppose this could be a case of duplicate thinking but
> this patch looks very familiar.
Hm... Do you mean that this one is from your tree? Sorry then,
I didn't know this. I can resend it with From: <you> if you wish.
> Eric
Thanks,
Pavel
>> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>>
>> ---
>>
>> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
>> index 113cc72..277c8fa 100644
>> --- a/net/core/sysctl_net_core.c
>> +++ b/net/core/sysctl_net_core.c
>> @@ -13,8 +13,6 @@
>> #include <net/sock.h>
>> #include <net/xfrm.h>
>>
>> -#ifdef CONFIG_SYSCTL
>> -
>> ctl_table core_table[] = {
>> #ifdef CONFIG_NET
>> {
>> @@ -151,5 +149,3 @@ ctl_table core_table[] = {
>> },
>> { .ctl_name = 0 }
>> };
>> -
>> -#endif
>> --
>> 1.5.3.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2007-12-03 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-01 12:57 [PATCH net-2.6.25 1/6][CORE] Remove unneeded ifdefs from sysctl_net_core.c Pavel Emelyanov
2007-12-02 2:05 ` Eric W. Biederman
2007-12-03 8:57 ` Pavel Emelyanov [this message]
2007-12-03 11:06 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4753C511.6090105@openvz.org \
--to=xemul@openvz.org \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).