From: Laszlo Attila Toth <panther@balabit.hu>
To: netdev@vger.kernel.org
Subject: cassini driver skb->truesize bug
Date: Tue, 04 Dec 2007 15:19:07 +0100 [thread overview]
Message-ID: <475561DB.7080404@balabit.hu> (raw)
Hello,
we got the following message:
SKB BUG: Invalid truesize (376) len=514, sizeof(sk_buff)=248
It only occurs on larger traffic (at speed 100 Mbps: always), but not
when downloading a small web page.
In cas_rx_process_pkt() the the skb's truesize is only set via skb_put()
but it is not used if there are fragments, also skb->len is increased by
the fragment's size, but the truesize member is unchanged. I compared it
to the implementation in e1000 where all of the len, datalen and
trusize members are increased.
If I modify the code to add the fragment's size to the truesize member,
the driver allocates all available memory after a while.
Regards,
Attila
next reply other threads:[~2007-12-04 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 14:19 Laszlo Attila Toth [this message]
2007-12-05 10:23 ` cassini driver skb->truesize bug Balazs Scheidler
2007-12-05 10:41 ` David Miller
2007-12-05 17:30 ` KOVACS Krisztian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475561DB.7080404@balabit.hu \
--to=panther@balabit.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).