From: Jarek Poplawski <jarkao2@gmail.com>
To: Joonwoo Park <joonwpark81@gmail.com>
Cc: netdev@vger.kernel.org,
'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>
Subject: Re: NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning
Date: Tue, 04 Dec 2007 23:26:54 +0100 [thread overview]
Message-ID: <4755D42E.7050602@gmail.com> (raw)
In-Reply-To: <000001c8365a$e0e500c0$9c94fea9@jason>
Joonwoo Park wrote, On 12/04/2007 10:48 AM:
> Hi,
> dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by netif_tx_lock_bh)
> therefore __dev_set_promiscuity can be called with softirq disabled.
> It will cause in_interrupt() to return true and ASSERT_RTNL warning.
> Is there a good solution to fix it besides blowing ASSERT_RTNL up?
Fixing ASSERT_RTNL up?!
But, IMHO, blowing ASSERT_RTNL up in a few places shouldn't be much
worse. After all, how long such a debugging code should be kept. It
seems, at least sometimes we should be a bit more confident of how
it's called.
Regards,
Jarek P.
next prev parent reply other threads:[~2007-12-04 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 9:48 NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning Joonwoo Park
2007-12-04 22:26 ` Jarek Poplawski [this message]
2007-12-05 6:25 ` Jarek Poplawski
2007-12-04 22:38 ` Herbert Xu
2007-12-05 5:30 ` [PATCH] " Joonwoo Park
2007-12-05 5:36 ` Herbert Xu
2007-12-05 5:56 ` Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4755D42E.7050602@gmail.com \
--to=jarkao2@gmail.com \
--cc=joonwpark81@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).