netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit
Date: Wed, 05 Dec 2007 13:41:24 +0100	[thread overview]
Message-ID: <47569C74.9020008@cosmosbay.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi David

Building last net-2.6.25 git tree gave me this warning :

WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to 
.exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')

This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).

I am not sure the following is the right fix, since __exit_refok is quite new, 
and seldom used.

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>


[-- Attachment #2: br_fdb_fini.patch --]
[-- Type: text/plain, Size: 311 bytes --]

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index eb57502..6caeba5 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -44,7 +44,7 @@ int __init br_fdb_init(void)
 	return 0;
 }
 
-void __exit br_fdb_fini(void)
+void __exit_refok br_fdb_fini(void)
 {
 	kmem_cache_destroy(br_fdb_cache);
 }

             reply	other threads:[~2007-12-05 12:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 12:41 Eric Dumazet [this message]
2007-12-05 12:49 ` [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit Stephen Hemminger
2007-12-05 13:07 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47569C74.9020008@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).