[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

[Eric Dumazet]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi David

Building last net-2.6.25 git tree gave me this warning :

WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to 
.exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')

This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).

I am not sure the following is the right fix, since __exit_refok is quite new, 
and seldom used.

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>


[-- Attachment #2: br_fdb_fini.patch --]
[-- Type: text/plain, Size: 311 bytes --]

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index eb57502..6caeba5 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -44,7 +44,7 @@ int __init br_fdb_init(void)
 	return 0;
 }
 
-void __exit br_fdb_fini(void)
+void __exit_refok br_fdb_fini(void)
 {
 	kmem_cache_destroy(br_fdb_cache);
 }

Re: [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

[Stephen Hemminger]

On Wed, 05 Dec 2007 13:41:24 +0100
Eric Dumazet <dada1@cosmosbay.com> wrote:

> Hi David
> 
> Building last net-2.6.25 git tree gave me this warning :
> 
> WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to 
> .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')
> 
> This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).
> 
> I am not sure the following is the right fix, since __exit_refok is quite new, 
> and seldom used.
> 
> [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> 

Andrew put a patch in his tree to just take off the __exit.
That seems like the easiest fix for a one line function.

Re: [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

[David Miller]

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed, 05 Dec 2007 13:41:24 +0100

> Building last net-2.6.25 git tree gave me this warning :
> 
> WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to 
> .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')
> 
> This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).
> 
> I am not sure the following is the right fix, since __exit_refok is quite new, 
> and seldom used.
> 
> [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

I have another patch like this from Andrew's -mm queue sitting
in my inbox, which I'll review and apply.

Thanks!