netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro
@ 2007-12-07 16:19 Pavel Emelyanov
  2007-12-08  1:37 ` Herbert Xu
  2007-12-11 10:17 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Pavel Emelyanov @ 2007-12-07 16:19 UTC (permalink / raw)
  To: David Miller; +Cc: Linux Netdev List, devel, Herbert Xu

This is essentially IN_DEV_ANDCONF with proper arguments.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h
index dd093ea..962a062 100644
--- a/include/linux/inetdevice.h
+++ b/include/linux/inetdevice.h
@@ -78,9 +78,7 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev)
 	(max(IPV4_DEVCONF_ALL(attr), IN_DEV_CONF_GET((in_dev), attr)))
 
 #define IN_DEV_FORWARD(in_dev)		IN_DEV_CONF_GET((in_dev), FORWARDING)
-#define IN_DEV_MFORWARD(in_dev)		(IPV4_DEVCONF_ALL(MC_FORWARDING) && \
-					 IPV4_DEVCONF((in_dev)->cnf, \
-						      MC_FORWARDING))
+#define IN_DEV_MFORWARD(in_dev)		IN_DEV_ANDCONF((in_dev), MC_FORWARDING)
 #define IN_DEV_RPFILTER(in_dev)		IN_DEV_ANDCONF((in_dev), RP_FILTER)
 #define IN_DEV_SOURCE_ROUTE(in_dev)	IN_DEV_ANDCONF((in_dev), \
 						       ACCEPT_SOURCE_ROUTE)
-- 
1.5.3.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro
  2007-12-07 16:19 [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro Pavel Emelyanov
@ 2007-12-08  1:37 ` Herbert Xu
  2007-12-11 10:17 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2007-12-08  1:37 UTC (permalink / raw)
  To: Pavel Emelyanov; +Cc: David Miller, Linux Netdev List, devel

On Fri, Dec 07, 2007 at 07:19:38PM +0300, Pavel Emelyanov wrote:
> This is essentially IN_DEV_ANDCONF with proper arguments.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks Pavel! I must have written that one before writing the
AND macro :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro
  2007-12-07 16:19 [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro Pavel Emelyanov
  2007-12-08  1:37 ` Herbert Xu
@ 2007-12-11 10:17 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-12-11 10:17 UTC (permalink / raw)
  To: xemul; +Cc: netdev, devel, herbert

From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 07 Dec 2007 19:19:38 +0300

> This is essentially IN_DEV_ANDCONF with proper arguments.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-12-11 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-07 16:19 [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro Pavel Emelyanov
2007-12-08  1:37 ` Herbert Xu
2007-12-11 10:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).