From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: Reproducible data corruption with sendfile+vsftp - splice regression? Date: Sat, 08 Dec 2007 10:28:02 -0500 Message-ID: <475AB802.1090003@rtr.ca> References: <474FC4D9.3020506@cosmosbay.com> <475055EE.9060105@hp.com> <20071205225429.GA10186@electric-eye.fr.zoreil.com> <20071206184426.GA32599@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Holger Hoffstaette , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, torvalds@linux-foundation.org To: Francois Romieu Return-path: Received: from rtr.ca ([76.10.145.34]:3347 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbXLHP2E (ORCPT ); Sat, 8 Dec 2007 10:28:04 -0500 In-Reply-To: <20071206184426.GA32599@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-ID: Francois Romieu wrote: > Holger Hoffstaette : > [...] >> Maybe turning off sendfile or NAPI just lead to random success - so far it >> really looks like tso on the r8169 is the common cause. > > TSO on the r8169 is the magic switch but the regression makes imvho more > sense from a VM pov: > > - the corrupted file has the same size as the expected file > - the corrupted file exhibits holes which come as a multiple of 4096 bytes > (8*4k, 2 places, there may be more) ... That's interesting. I had the those exact same symptoms here with copying data to/from a USB stick recently. But that stick died completely shortly thereafter, so this was written-off as "bad hardware". Strange that you see the same symptoms from a different scenario. Probably no relationship there, but ..