From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [PATCH net-2.6.25] qdisc: new rate limiter Date: Sat, 08 Dec 2007 13:59:11 -0800 Message-ID: <475B13AF.9090507@candelatech.com> References: <20071207162618.35715892@freepuppy.rosehill> <475A0804.1060006@trash.net> <475A0959.20701@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , "David S. Miller" , netdev@vger.kernel.org To: Patrick McHardy Return-path: Received: from ns2.lanforge.com ([66.165.47.211]:41731 "EHLO ns2.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbXLHV7S (ORCPT ); Sat, 8 Dec 2007 16:59:18 -0500 In-Reply-To: <475A0959.20701@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: Patrick McHardy wrote: > Patrick McHardy wrote: >> Stephen Hemminger wrote: >>> >>> +struct tc_rlim_qopt >>> +{ >>> + __u32 limit; /* fifo limit (packets) */ >>> + __u32 rate; /* bits per sec */ >>> >> >> This seems a bit small, 512mbit is the maximum rate. > > Its 4gbit of course, so I guess its enough :) Even 4Gbps is well within the means of today's commodity hardware...seems easier to bump to 64 bits now rather than have to make some backwards-compat hack a year from now... Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com