* Re: [PATCH 3/3] Fix use of skb after netif_rx
[not found] ` <Pine.LNX.4.64.0712100813440.13319@ask.diku.dk>
@ 2007-12-10 7:35 ` Wang Chen
0 siblings, 0 replies; only message in thread
From: Wang Chen @ 2007-12-10 7:35 UTC (permalink / raw)
To: Julia Lawall; +Cc: fpavlic, linux-kernel, kernel-janitors, Jeff Garzik, netdev
Julia Lawall said the following on 2007-12-10 15:18:
>> Julia, seems that your semantic patch misses following place.
>>
>> drivers/s390/net/qeth_main.c:2733
>> ...
>> #endif
>> rxrc = netif_rx(skb);
>> card->dev->last_rx = jiffies;
>> card->stats.rx_packets++;
>> card->stats.rx_bytes += skb->len;
>> ...
>
> Actually, I found this one as well, but I wasn't sure what to do with it.
> This one is a bit more complicated because the line with the call to
> netif_rx is in an else branch if the #ifdef above is taken. So I wasn't
> sure what would be the best way to solve the problem in this case.
>
> Perhaps the solution would be just to save the value of the len field
> in a local variable in this case, as you proposed in your original patch.
>
I agree.
BTW, please send driver patch to Jeff Garzik <jgarzik@pobox.com> and
cc to netdev@vger.kernel.org.
--
WCN
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-10 7:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.64.0712092103560.11165@ask.diku.dk>
[not found] ` <475CA464.1060408@cn.fujitsu.com>
[not found] ` <Pine.LNX.4.64.0712100813440.13319@ask.diku.dk>
2007-12-10 7:35 ` [PATCH 3/3] Fix use of skb after netif_rx Wang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).