From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Chen Subject: Re: [PATCH 3/3] Fix use of skb after netif_rx Date: Mon, 10 Dec 2007 15:35:10 +0800 Message-ID: <475CEC2E.4040006@cn.fujitsu.com> References: <475CA464.1060408@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: fpavlic@de.ibm.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jeff Garzik , netdev@vger.kernel.org To: Julia Lawall Return-path: Received: from [222.73.24.84] ([222.73.24.84]:57513 "EHLO song.cn.fujitsu.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751572AbXLJHiH (ORCPT ); Mon, 10 Dec 2007 02:38:07 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Julia Lawall said the following on 2007-12-10 15:18: >> Julia, seems that your semantic patch misses following place. >> >> drivers/s390/net/qeth_main.c:2733 >> ... >> #endif >> rxrc = netif_rx(skb); >> card->dev->last_rx = jiffies; >> card->stats.rx_packets++; >> card->stats.rx_bytes += skb->len; >> ... > > Actually, I found this one as well, but I wasn't sure what to do with it. > This one is a bit more complicated because the line with the call to > netif_rx is in an else branch if the #ifdef above is taken. So I wasn't > sure what would be the best way to solve the problem in this case. > > Perhaps the solution would be just to save the value of the len field > in a local variable in this case, as you proposed in your original patch. > I agree. BTW, please send driver patch to Jeff Garzik and cc to netdev@vger.kernel.org. -- WCN