* [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE
@ 2007-12-10 19:29 Richard Knutsson
2007-12-10 19:54 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Richard Knutsson @ 2007-12-10 19:29 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, linux-kernel, Richard Knutsson
Remove local definition of TRUE/FALSE.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
index d5d092c..4484778 100644
--- a/drivers/net/ipg.h
+++ b/drivers/net/ipg.h
@@ -490,38 +490,34 @@ enum ipg_regs {
* Tune
*/
-/* Miscellaneous Constants. */
-#define TRUE 1
-#define FALSE 0
-
/* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
-#define IPG_APPEND_FCS_ON_TX TRUE
+#define IPG_APPEND_FCS_ON_TX true
/* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS strip on RX. */
-#define IPG_STRIP_FCS_ON_RX TRUE
+#define IPG_STRIP_FCS_ON_RX true
/* Assign IPG_DROP_ON_RX_ETH_ERRORS > 0 to drop RX frames with
* Ethernet errors.
*/
-#define IPG_DROP_ON_RX_ETH_ERRORS TRUE
+#define IPG_DROP_ON_RX_ETH_ERRORS true
/* Assign IPG_INSERT_MANUAL_VLAN_TAG > 0 to insert VLAN tags manually
* (via TFC).
*/
-#define IPG_INSERT_MANUAL_VLAN_TAG FALSE
+#define IPG_INSERT_MANUAL_VLAN_TAG false
/* Assign IPG_ADD_IPCHECKSUM_ON_TX > 0 for auto IP checksum on TX. */
-#define IPG_ADD_IPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_IPCHECKSUM_ON_TX false
/* Assign IPG_ADD_TCPCHECKSUM_ON_TX > 0 for auto TCP checksum on TX.
* DO NOT USE FOR SILICON REVISIONS B3 AND EARLIER.
*/
-#define IPG_ADD_TCPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_TCPCHECKSUM_ON_TX false
/* Assign IPG_ADD_UDPCHECKSUM_ON_TX > 0 for auto UDP checksum on TX.
* DO NOT USE FOR SILICON REVISIONS B3 AND EARLIER.
*/
-#define IPG_ADD_UDPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_UDPCHECKSUM_ON_TX false
/* If inserting VLAN tags manually, assign the IPG_MANUAL_VLAN_xx
* constants as desired.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE
2007-12-10 19:29 [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE Richard Knutsson
@ 2007-12-10 19:54 ` Pekka Enberg
2007-12-10 20:04 ` Richard Knutsson
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Enberg @ 2007-12-10 19:54 UTC (permalink / raw)
To: Richard Knutsson; +Cc: jgarzik, netdev, linux-kernel, romieu
Hi Richard,
On Dec 10, 2007 9:29 PM, Richard Knutsson <ricknu-0@student.ltu.se> wrote:
> Remove local definition of TRUE/FALSE.
This is already fixed in Francois' tree:
http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99
Pekka
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE
2007-12-10 19:54 ` Pekka Enberg
@ 2007-12-10 20:04 ` Richard Knutsson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Knutsson @ 2007-12-10 20:04 UTC (permalink / raw)
To: Pekka Enberg; +Cc: jgarzik, netdev, linux-kernel, romieu
Pekka Enberg wrote:
> Hi Richard,
>
> On Dec 10, 2007 9:29 PM, Richard Knutsson <ricknu-0@student.ltu.se> wrote:
>
>> Remove local definition of TRUE/FALSE.
>>
>
> This is already fixed in Francois' tree:
>
> http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99
>
I see, thanks.
Richard Knutsson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-10 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-10 19:29 [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE Richard Knutsson
2007-12-10 19:54 ` Pekka Enberg
2007-12-10 20:04 ` Richard Knutsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).