From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kok, Auke" Subject: Re: 2.6.24-rc4-mm1 Date: Tue, 11 Dec 2007 14:17:16 -0800 Message-ID: <475F0C6C.20900@intel.com> References: <20071204211701.994dfce6.akpm@linux-foundation.org> <33307c790712110813h23def95dvd068b7226e9fcd36@mail.gmail.com> <20071211123705.844aac24.akpm@linux-foundation.org> <475F00A2.6020406@intel.com> <20071211141040.a1c6f316.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mbligh@google.com, linux-kernel@vger.kernel.org, apw@shadowen.org, netdev@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu To: Andrew Morton Return-path: In-Reply-To: <20071211141040.a1c6f316.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Andrew Morton wrote: > On Tue, 11 Dec 2007 13:26:58 -0800 > "Kok, Auke" wrote: > >> Andrew Morton wrote: >>> On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" wrote: >>> >>>>> - Lots of device IDs have been removed from the e1000 driver and moved >>>>> over >>>>> to e1000e. So if your e1000 stops working, you forgot to set >>>>> CONFIG_E1000E. >>>>> >>>>> >>>> Wouldn't it make sense to just default this to on if E1000 was on, rather >>>> than screwing >>>> everybody for no good reason (plus breaking all the automated testing, etc >>>> etc)? >>>> Much though I love random refactoring, it is fairly painful to just keep >>>> changing the >>>> names of things. >>> (cc netdev and Auke) >>> >>> Yes, that would be very sensible. CONFIG_E1000E should default to whatever >>> CONFIG_E1000 was set to. >> which is "y" for x86 and friends, ppc, arm and ia64 through 'defconfig'. the >> Kconfig files do not have defaults in them. > > I wouldn't be looking at defconfig files - I don't think many people use > them. Most people use their previous config, via oldconfig. > > So what we want here is to give them E1000E if they had previously been > using E1000. I don't know how one would do this in Kconfig. ditto. I doubt that "SELECT E1000E" would be a good idea here (maybe not even work), and I can't think of anything else. Auke