netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dor Laor <dor.laor@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
	kvm-devel <kvm-devel@lists.sourceforge.net>,
	netdev@vger.kernel.org,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit
Date: Wed, 12 Dec 2007 14:54:00 +0200	[thread overview]
Message-ID: <475FD9E8.1060109@qumranet.com> (raw)

commit 763769621d271d92204ed27552d75448587c1ac0
Author: Dor Laor <dor.laor@qumranet.com>
Date:   Wed Dec 12 14:52:00 2007 +0200

    [virtio-net][PATCH] Don't arm tx hrtimer with a constant 50us each 
transmit
   
    The current start_xmit sets 500us hrtimer to kick the host.
    The problem is that if another xmit happens before the timer was 
fired then
    the first xmit will have to wait additional 500us.
    This patch does not re-arm the timer if there is existing one.
    This will shorten the latency for tx.
   
    Signed-off-by: Dor Laor <dor.laor@qumranet.com>

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 7b051d5..8bb17d1
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -406,10 +405,10 @@ again:
         virtio_debug(vdebug, "%s: before calling kick %d\n", 
__FUNCTION__, __LINE__);
         vi->svq->vq_ops->kick(vi->svq);
         vi->out_num = 0;
-    } else {
-        vi->stats.hrtimer_starts++;
-        hrtimer_start(&vi->tx_timer, ktime_set(0,500000),
-                  HRTIMER_MODE_REL);
+    } else if (!hrtimer_is_queued(&vi->tx_timer)) {
+            vi->stats.hrtimer_starts++;
+            hrtimer_start(&vi->tx_timer, ktime_set(0,500000),
+                      HRTIMER_MODE_REL);
     }
     return 0;
 }


             reply	other threads:[~2007-12-12 12:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12 12:54 Dor Laor [this message]
2007-12-12 13:19 ` [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit Christian Borntraeger
2007-12-12 14:17   ` Dor Laor
2007-12-12 16:33     ` Christian Borntraeger
     [not found]       ` <200712121733.07804.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-12-13  8:44         ` Dor Laor
2007-12-18  0:01 ` Rusty Russell
     [not found]   ` <200712181101.14916.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2007-12-18  5:30     ` Avi Kivity
     [not found]       ` <47675AE0.8050808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-18  7:24         ` Rusty Russell
2007-12-18 12:55     ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475FD9E8.1060109@qumranet.com \
    --to=dor.laor@gmail.com \
    --cc=dor.laor@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).