From: "Denis V. Lunev" <den@sw.ru>
To: David Miller <davem@davemloft.net>
Cc: den@openvz.org, containers@lists.osdl.org, devel@openvz.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
Date: Thu, 13 Dec 2007 18:01:32 +0300 [thread overview]
Message-ID: <4761494C.4000202@sw.ru> (raw)
In-Reply-To: <20071213.065045.189743239.davem@davemloft.net>
David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Thu, 13 Dec 2007 17:18:42 +0300
>
>> There are to many spaces between type and function name in the declaration
>> of fib rules manipulation routines. Eat them and save a couple of lines.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>
> This is just noise and serves nothing other than to invite potential
> patch conflicts which makes development harder.
>
> If you happened to be changing these for other reasons, I'd say OK,
> but not like this.
>
I will add parameter to these calls. The line will be too long after
that. I'd like to separate sense changes from, you perfectly correct,
useless changes :(
Could you still apply it, or I will need to send fully functional set to
you including this?
next prev parent reply other threads:[~2007-12-13 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 14:18 [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h Denis V. Lunev
[not found] ` <20071213141842.GA9939-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2007-12-13 14:47 ` [Devel] " Alexey Dobriyan
2007-12-13 14:49 ` David Miller
2007-12-13 14:50 ` David Miller
2007-12-13 15:01 ` Denis V. Lunev [this message]
2007-12-13 15:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761494C.4000202@sw.ru \
--to=den@sw.ru \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).