From: Robert Stonehouse <rstonehouse@solarflare.com>
To: netdev@vger.kernel.org
Cc: linux-net-drivers@solarflare.com, spope@solarflare.com
Subject: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller - 2nd try
Date: Thu, 13 Dec 2007 19:18:38 +0000 [thread overview]
Message-ID: <4761858E.2040709@solarflare.com> (raw)
This is a resubmission of a new driver for Solarflare network controllers.
The driver supports many types of PHY (10Gbase-T, XFP, CX4) on five
different 10G reference designs and one 1G NIC ref design.
The previous thread was:
"[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller"
http://marc.info/?l=linux-netdev&m=119583775622559&w=2
Since the 1st patch we have addressed the review comments we received
- removed usage of __LINK_STATE_START as unnecessary with latest NAPI
- cleaned up many checkpatch violations
- used the generic drv_* logging
(macros were kept so that the network device name can be printed
consistently in all messaging but these can be dissolved if necessary)
- Reduced over-use of docbook type comments
- replaced uintN_t with uN types
- merged some small headers to reduce the file count
It is still quite a large driver at ~25k LOC. The main body of the driver
is within efx.c, falcon.c, tx.c and rx.c if this helps direct review effort.
We welcome more review comments and will try and respond to them more
quickly than last time.
The patch (against net-2.6.25) is at:
https://support.solarflare.com/netdev/2/net-2.6.25-sfc-2.2.0026.patch
The new files may also be downloaded as a tarball:
https://support.solarflare.com/netdev/2/net-2.6.25-sfc-2.2.0026.tgz
And for verification there is:
https://support.solarflare.com/netdev/2/MD5SUMS
Regards
--
Rob Stonehouse
reply other threads:[~2007-12-13 19:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761858E.2040709@solarflare.com \
--to=rstonehouse@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=spope@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).