From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Peter Tyser <ptyser@xes-inc.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: RX lockup fix
Date: Fri, 14 Dec 2007 15:26:59 -0500 [thread overview]
Message-ID: <4762E713.1070605@pobox.com> (raw)
In-Reply-To: <20071207152215.0267c407@freepuppy.rosehill>
Stephen Hemminger wrote:
> I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX
> lockups while validating the sky2 driver. The receive MAC FIFO would
> become stuck during testing with high traffic. One port of the 88E8062
> would lockup, while the other port remained functional. Re-inserting
> the sky2 module would not fix the problem - only a power cycle would.
>
> I looked over Marvell's most recent sk98lin driver and it looks like
> they had a "workaround" for the Yukon XL that the sky2 doesn't have yet.
> The sk98lin driver disables the RX MAC FIFO flush feature for all
> revisions of the Yukon XL.
>
> According to skgeinit.c of the sk98lin driver, "Flushing must be enabled
> (needed for ASF see dev. #4.29), but the flushing mask should be
> disabled (see dev. #4.115)". Nice. I implemented this same change in
> the sky2 driver and verified that the RX lockup I was seeing was
> resolved.
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> ---
> Original patch reformatted to remove line wrap.
applied #upstream-fixes
prev parent reply other threads:[~2007-12-14 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 18:51 [PATCH] sky2: RX lockup fix Peter Tyser
2007-12-05 21:40 ` Stephen Hemminger
2007-12-06 0:18 ` Peter Tyser
2007-12-06 3:52 ` Stephen Hemminger
2007-12-06 16:14 ` Peter Tyser
2007-12-07 23:22 ` Stephen Hemminger
2007-12-14 20:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4762E713.1070605@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).