* [PATCH] e100: free IRQ to remove warningwhenrebooting
@ 2007-12-13 0:30 Auke Kok
2007-12-14 20:27 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Auke Kok @ 2007-12-13 0:30 UTC (permalink / raw)
To: jeff; +Cc: netdev, jesse.brandeburg, ianw
Adapted from Ian Wienand <ianw@gelato.unsw.edu.au>
Explicitly free the IRQ before removing the device to remove a
warning "Destroying IRQ without calling free_irq"
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Cc: Ian Wienand <ianw@gelato.unsw.edu.au>
---
drivers/net/e100.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 27f4d4a..f630ea9 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -2807,8 +2807,9 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
pci_enable_wake(pdev, PCI_D3cold, 0);
}
- pci_disable_device(pdev);
free_irq(pdev->irq, netdev);
+
+ pci_disable_device(pdev);
pci_set_power_state(pdev, PCI_D3hot);
return 0;
@@ -2850,6 +2851,8 @@ static void e100_shutdown(struct pci_dev *pdev)
pci_enable_wake(pdev, PCI_D3cold, 0);
}
+ free_irq(pdev->irq, netdev);
+
pci_disable_device(pdev);
pci_set_power_state(pdev, PCI_D3hot);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] e100: free IRQ to remove warningwhenrebooting
2007-12-13 0:30 [PATCH] e100: free IRQ to remove warningwhenrebooting Auke Kok
@ 2007-12-14 20:27 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-12-14 20:27 UTC (permalink / raw)
To: Auke Kok; +Cc: netdev, jesse.brandeburg, ianw
Auke Kok wrote:
> Adapted from Ian Wienand <ianw@gelato.unsw.edu.au>
>
> Explicitly free the IRQ before removing the device to remove a
> warning "Destroying IRQ without calling free_irq"
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: Ian Wienand <ianw@gelato.unsw.edu.au>
> ---
>
> drivers/net/e100.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
applied #upstream-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-14 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-13 0:30 [PATCH] e100: free IRQ to remove warningwhenrebooting Auke Kok
2007-12-14 20:27 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).