netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
To: David Miller <davem@davemloft.net>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	Ralf Baechle DL5RB <ralf@linux-mips.org>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] [AX25] circular locking with AX25 connection timeout
Date: Fri, 14 Dec 2007 23:29:28 +0100	[thread overview]
Message-ID: <476303C8.2060507@ccr.jussieu.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 136 bytes --]

Hi,

This patch cancels a circular locking conflict that appeared with a 
timeout of an AX25 connection.

signed off by Jarek Poplawski

[-- Attachment #2: rose-2.6.24-rc5.patch3 --]
[-- Type: text/plain, Size: 472 bytes --]

--- linux-2.6.24-rc5/net/ax25/ax25_subr.c	2007-12-11 04:48:43.000000000 +0100
+++ b/net/ax25/ax25_subr.c	2007-12-14 14:30:02.000000000 +0100
@@ -279,6 +279,7 @@
 	ax25_link_failed(ax25, reason);
 
 	if (ax25->sk != NULL) {
+		local_bh_disable();
 		bh_lock_sock(ax25->sk);
 		ax25->sk->sk_state     = TCP_CLOSE;
 		ax25->sk->sk_err       = reason;
@@ -288,5 +289,6 @@
 			sock_set_flag(ax25->sk, SOCK_DEAD);
 		}
 		bh_unlock_sock(ax25->sk);
+		local_bh_enable(); 
 	}
 }

             reply	other threads:[~2007-12-14 22:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 22:29 Bernard Pidoux [this message]
2007-12-15 10:18 ` [PATCH take2] [AX25] circular locking with AX25 connection timeout Jarek Poplawski
2007-12-16 21:17   ` [BUG] lack of /proc/net/ax25 with 2.6.24-rc5 Bernard Pidoux
2007-12-17 21:56     ` Rafael J. Wysocki
2007-12-17 22:44     ` [PATCH] sysctl: Fix ax25 checks Eric W. Biederman
2007-12-18  0:08       ` Bernard Pidoux
2007-12-18  0:16         ` Eric W. Biederman
2007-12-18  6:59       ` David Miller
2007-12-16 22:02   ` [PATCH take2] [AX25] circular locking with AX25 connection timeout David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476303C8.2060507@ccr.jussieu.fr \
    --to=pidoux@ccr.jussieu.fr \
    --cc=davem@davemloft.net \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).