From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
To: "David S. Miller" <davem@davemloft.net>
Cc: Ralf Baechle DL5RB <ralf@linux-mips.org>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] [ROSE] ax25_send_frame() called with a constant paclen = 260
Date: Fri, 14 Dec 2007 23:49:11 +0100 [thread overview]
Message-ID: <47630867.5040404@ccr.jussieu.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
Hi,
In rose_link.c ax25_send_frame() was called with a constant paclen
parameter of 260 bytes.
This value looked odd to me for it did not correspond to any defined or
possible computed length.Replacing this value by 0 (zero) allowed
ax25_send_frame() to substitute it by the default AX25 frame size, which
in turn induced significant results on the AX25 frame fragmentation and
removed some garbage trailing characters in AX25 frames sent.
signed off by Bernard Pidoux, f6bvp@amsat.org
[-- Attachment #2: rose-2.6.24-rc5.patch6 --]
[-- Type: text/plain, Size: 438 bytes --]
--- linux-2.6.24-rc5/net/rose/rose_link.c 2007-12-11 04:48:43.000000000 +0100
+++ b/net/rose/rose_link.c 2007-12-14 14:39:23.000000000 +0100
@@ -107,7 +107,7 @@
else
rose_call = &rose_callsign;
- neigh->ax25 = ax25_send_frame(skb, 260, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
+ neigh->ax25 = ax25_send_frame(skb, 0, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
return (neigh->ax25 != NULL);
}
reply other threads:[~2007-12-14 22:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47630867.5040404@ccr.jussieu.fr \
--to=pidoux@ccr.jussieu.fr \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).