* [PATCH] [ROSE] ax25_send_frame() called with a constant paclen = 260
@ 2007-12-14 22:49 Bernard Pidoux
0 siblings, 0 replies; only message in thread
From: Bernard Pidoux @ 2007-12-14 22:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Ralf Baechle DL5RB, Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
Hi,
In rose_link.c ax25_send_frame() was called with a constant paclen
parameter of 260 bytes.
This value looked odd to me for it did not correspond to any defined or
possible computed length.Replacing this value by 0 (zero) allowed
ax25_send_frame() to substitute it by the default AX25 frame size, which
in turn induced significant results on the AX25 frame fragmentation and
removed some garbage trailing characters in AX25 frames sent.
signed off by Bernard Pidoux, f6bvp@amsat.org
[-- Attachment #2: rose-2.6.24-rc5.patch6 --]
[-- Type: text/plain, Size: 438 bytes --]
--- linux-2.6.24-rc5/net/rose/rose_link.c 2007-12-11 04:48:43.000000000 +0100
+++ b/net/rose/rose_link.c 2007-12-14 14:39:23.000000000 +0100
@@ -107,7 +107,7 @@
else
rose_call = &rose_callsign;
- neigh->ax25 = ax25_send_frame(skb, 260, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
+ neigh->ax25 = ax25_send_frame(skb, 0, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
return (neigh->ax25 != NULL);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-14 22:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-14 22:49 [PATCH] [ROSE] ax25_send_frame() called with a constant paclen = 260 Bernard Pidoux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).