From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000 Date: Fri, 14 Dec 2007 15:54:14 -0800 Message-ID: <476317A6.3060302@linux-foundation.org> References: <200712140002.lBE02pUb025505@imap1.linux-foundation.org> <4762E9FE.1070707@garzik.org> <20071214152215.55ef46e8.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Garzik , netdev@vger.kernel.org, randy.dunlap@oracle.com, auke-jan.h.kok@intel.com, linux-kernel@vger.kernel.org To: Andrew Morton Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:54866 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbXLNXy0 (ORCPT ); Fri, 14 Dec 2007 18:54:26 -0500 In-Reply-To: <20071214152215.55ef46e8.akpm@linux-foundation.org> Sender: netdev-owner@vger.kernel.org List-ID: Andrew Morton wrote: > On Fri, 14 Dec 2007 15:39:26 -0500 > Jeff Garzik wrote: > > >> akpm@linux-foundation.org wrote: >> >>> From: Randy Dunlap >>> >>> Make E1000E default to the same kconfig setting as E1000. So people's >>> machiens don't stop working when they use oldconfig. >>> >>> Signed-off-by: Randy Dunlap >>> Cc: Jeff Garzik >>> Cc: Auke Kok >>> Signed-off-by: Andrew Morton >>> --- >>> >>> drivers/net/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff -puN drivers/net/Kconfig~e1000e-make-e1000e-default-to-the-same-kconfig-setting-as-e1000 drivers/net/Kconfig >>> --- a/drivers/net/Kconfig~e1000e-make-e1000e-default-to-the-same-kconfig-setting-as-e1000 >>> +++ a/drivers/net/Kconfig >>> @@ -1986,6 +1986,7 @@ config E1000_DISABLE_PACKET_SPLIT >>> config E1000E >>> tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" >>> depends on PCI >>> + default E1000 >>> >> I am not inclined to apply this one. This practice, applied over time, >> will tend to accumulate weird 'default' and 'select' statements. >> >> So I think the breakage that occurs is mitigated by two factors: >> 1) kernel hackers that do their own configs are expected to be able to >> figure this stuff. >> 2) kernel builders (read: distros, mainly) are expected to have put >> thought into the Kconfig selection and driver migration strategies. >> >> PCI IDs move across drivers from time, and we don't want to apply these >> sorts changes: Viewed in the long term, the suggested patch is merely a >> temporary change to allow kernel experts to more easily deal with the >> PCI ID migration across drivers. >> >> I would prefer simply to communicate to kernel experts and builders >> about a Kconfig issue that could potentially their booting/networking... >> because this patch is only needed if the kernel experts do not already >> know about a necessary config update. >> > > You can take it out again later on - most people's .configs will then have > E1000E set. People who still do `cp ancientconfig .config ; make oldconfig' > remain screwed. > Sounds like something build system should help with. Some more user friendly syntax for dealing with issues of driver conversion.