From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Auke Kok <auke-jan.h.kok@intel.com>,
jeff@garzik.org, netdev@vger.kernel.org, davem@davemloft.net,
john.ronciak@intel.com, jesse.brandeburg@intel.com,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum
Date: Sat, 15 Dec 2007 12:35:35 -0800 [thread overview]
Message-ID: <47643A97.7050309@intel.com> (raw)
In-Reply-To: <1197682306.4861.72.camel@localhost>
Joe Perches wrote:
> On Fri, 2007-12-14 at 15:35 -0800, Auke Kok wrote:
>> + printk(KERN_ERR "/*********************/\n");
>> + printk(KERN_ERR "Current EEPROM: 0x%04x\nCalculated : 0x%04x\n",
>> + csum_old, csum_new);
>
> Multiline printks need a KERN_<level> after every newline. Perhaps:
>
> printk(KERN_ERR "Current EEPROM: 0x%04x\n"
> KERN_ERR "Calculated : 0x%04x\n",
> csum_old, csum_new);
>
>> + printk(KERN_ERR "Offset Values\n");
>> + printk(KERN_ERR "====== ======\n");
>> + for (i = 0; i < eeprom.len; i += 16)
>> + printk(KERN_ERR "0x%04x "
>> + "%02x %02x %02x %02x %02x %02x %02x %02x "
>> + "%02x %02x %02x %02x %02x %02x %02x %02x\n",
>> + i, data[i], data[i + 1], data[i + 2], data[i + 3],
>> + data[i + 4], data[i + 5], data[i + 6], data[i + 7],
>> + data[i + 8], data[i + 9], data[i + 10], data[i + 11],
>> + data[i + 12], data[i + 13], data[i + 14], data[i + 15]);
>
> print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 16, 1, data,
> eeprom.len, true);
>
>> + printk(KERN_ERR "Include this output when contacting your support "
>> + "provider.\n\nThis is not a software error! Something bad "
>> + "happened to your hardware or\nEEPROM image. Ignoring this "
>> + "problem could result in further problems,\npossibly loss "
>> + "of data, corruption or system hangs!\n\n");
>> + printk(KERN_ERR "The MAC Address will be reset to 00:00:00:00:00:00, "
>> + "which is invalid\nand requires you to set the proper MAC "
>> + "address manually before continuing\nto enable this network "
>> + "device.\n\n");
>> + printk(KERN_ERR "Please inspect the EEPROM dump and report the issue "
>> + "to your hardware vendor\nor Intel Customer Support: "
>> + "linux-nics@intel.com\n");
>
> multiline printks...
>
given these and Randy's comments I'll respin this and resubmit. thanks for the
comments!
Auke
next prev parent reply other threads:[~2007-12-15 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 23:35 [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum Auke Kok
2007-12-15 1:08 ` Randy Dunlap
2007-12-15 1:31 ` Joe Perches
2007-12-15 20:35 ` Kok, Auke [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-17 21:50 Auke Kok
2007-12-17 22:14 ` Joe Perches
2007-12-18 1:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47643A97.7050309@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).