From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, shemminger@linux-foundation.org,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
berrange@redhat.com, herbert@gondor.apana.org.au, rjw@sisk.pl
Subject: Re: [PATCH] bridge: assign random address
Date: Sun, 16 Dec 2007 20:46:24 -0500 [thread overview]
Message-ID: <4765D4F0.5040202@garzik.org> (raw)
In-Reply-To: <20071216.152606.35263254.davem@davemloft.net>
David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Sun, 16 Dec 2007 14:29:15 -0800
>
>> On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>>
>>> From: Stephen Hemminger <shemminger@linux-foundation.org>
>>> Date: Tue, 11 Dec 2007 15:48:35 -0800
>>>
>>>> Subject: Re: [PATCH] bridge: assign random address
>>> "bridge" should all-caps and in brackets,
>> No, "bridge" should not be in []. Lots of people's patch-receiving scripts
>> assume that any text in [] is to be removed as the patch is committed. It
>> contains text which is only relevant to the particular email which carried
>> the patch. Stuff like "patch" and "4/5" and "linux-2.6.23", etc.
>
> I don't use scripts, I edit it by hand. And when I do ever use
> scripts I will make sure they accomodate "[$SUBSYSTEM]" format
> subject lines, you can be sure.
>
> And you can even make those scripts happy by doing:
>
> [Patch 1/7] [SUBSYSTEM]: Foo bar baz...
The most popular tool is git-am, which I and many others use.
git-am will snip "[SUBSYSTEM]" in the example that you give.
Until Linus's official mail import tool (git-am) changes, I agree with
Andrew -- since Andrew is simply describing the de facto standard as it
exists today: [] gets eaten.
That's why documentation like Documentation/SubmittingPatches and
http://linux.yyz.us/patch-format.html indicate "subsystem: " rather than
"[SUBSYSTEM]": it's compatible with Linus's widely used mail import tool.
Jeff
next prev parent reply other threads:[~2007-12-17 1:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9545-10286@http.bugzilla.kernel.org/>
2007-12-11 21:26 ` [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set Andrew Morton
2007-12-11 22:52 ` Stephen Hemminger
2007-12-11 22:59 ` Andrew Morton
2007-12-11 23:48 ` [PATCH] bridge: assign random address Stephen Hemminger
2007-12-12 0:02 ` Andrew Morton
2007-12-16 21:37 ` David Miller
2007-12-16 22:29 ` Andrew Morton
2007-12-16 23:26 ` David Miller
2007-12-16 23:34 ` Andrew Morton
2007-12-16 23:40 ` David Miller
2007-12-16 23:46 ` Andrew Morton
2007-12-16 23:37 ` Randy Dunlap
2007-12-17 1:46 ` Jeff Garzik [this message]
2007-12-17 2:55 ` Andrew Morton
2007-12-17 4:36 ` David Miller
2007-12-17 4:24 ` David Miller
2007-12-18 1:09 ` Jeff Garzik
2007-12-17 16:56 ` Stephen Hemminger
2007-12-12 1:51 ` [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set Herbert Xu
2007-12-12 5:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4765D4F0.5040202@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=berrange@redhat.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).