From: Kazunori MIAZAWA <kazunori@miyazawa.org>
To: usagi-core@linux-ipv6.org
Cc: herbert@gondor.apana.org.au, miyazawa@taca.jp, netdev@vger.kernel.org
Subject: Re: (usagi-core 34069) Re: [IPSEC]: Do xfrm_state_check_space before encapsulation
Date: Wed, 19 Dec 2007 22:23:01 +0900 [thread overview]
Message-ID: <47691B35.5090209@miyazawa.org> (raw)
In-Reply-To: <20071218.221456.49781139.davem@davemloft.net>
David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Wed, 19 Dec 2007 14:12:10 +0800
>
>> [IPSEC]: Do xfrm_state_check_space before encapsulation
>>
>> While merging the IPsec output path I moved the encapsulation output
>> operation to the top of the loop so that it sits outside of the locked
>> section. Unfortunately in doing so it now sits in front of the space
>> check as well which could be a fatal error.
>>
>> This patch rearranges the calls so that the space check happens as
>> the thing on the output path.
>>
>> This patch also fixes an incorrect goto should the encapsulation output
>> fail.
>>
>> Thanks to Kazunori MIYAZAWA for finding this bug.
>>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Applied, thanks Herbert.
>
>
Thank you for your quick response :-)
--
Kazunori Miyazawa
prev parent reply other threads:[~2007-12-19 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4768A7CA.4090503@taca.jp>
2007-12-19 6:12 ` [IPSEC]: Do xfrm_state_check_space before encapsulation Herbert Xu
2007-12-19 6:14 ` David Miller
2007-12-19 13:23 ` Kazunori MIAZAWA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47691B35.5090209@miyazawa.org \
--to=kazunori@miyazawa.org \
--cc=herbert@gondor.apana.org.au \
--cc=miyazawa@taca.jp \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).