From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: parag.warudkar@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] e1000e: Use deferrable timer for watchdog
Date: Thu, 20 Dec 2007 09:05:07 -0800 [thread overview]
Message-ID: <476AA0C3.2080503@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712182046560.3616@mini.warudkars.net>
Parag Warudkar wrote:
>
> Reduce wakeups from idle per second.
>
> Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
>
> --- linux-2.6/drivers/net/e1000e/netdev.c 2007-12-07
> 10:04:39.000000000 -0500
> +++ linux-2.6-work/drivers/net/e1000e/netdev.c 2007-12-18
> 20:45:59.000000000 -0500
> @@ -3899,7 +3899,7 @@
> goto err_eeprom;
> }
>
> - init_timer(&adapter->watchdog_timer);
> + init_timer_deferrable(&adapter->watchdog_timer);
> adapter->watchdog_timer.function = &e1000_watchdog;
> adapter->watchdog_timer.data = (unsigned long) adapter;
I can't even apply this patch and the e1000 one... not only is it whitespace
damaged it is also not properly formatted as patch at all. If you want me to take
these patches seriously, then please fix the formatting issues.
Auke
next prev parent reply other threads:[~2007-12-20 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 1:49 [PATCH] e1000e: Use deferrable timer for watchdog Parag Warudkar
2007-12-19 19:04 ` Kok, Auke
2007-12-20 17:05 ` Kok, Auke [this message]
2007-12-20 17:56 ` Parag Warudkar
2007-12-20 18:49 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476AA0C3.2080503@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).