From: Jarek Poplawski <jarkao2@gmail.com>
To: Satoru SATOH <satoru.satoh@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly
Date: Thu, 20 Dec 2007 21:24:42 +0100 [thread overview]
Message-ID: <476ACF8A.7060201@gmail.com> (raw)
In-Reply-To: <d72b7ace0712200821k7cde0834rf1187b30c68cd1ce@mail.gmail.com>
Satoru SATOH wrote, On 12/20/2007 05:21 PM:
> i see. HZ can be < 1000.. i should be wrong.
>
> however, i got the following,
>
> [root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s
> [root iproute2.org]# gdb -q ./ip/ip
...
> (gdb) p hz
> $1 = 1000000000
That's why I had some doubts! I didn't study this enough, but my
(older) version definitely showed hz == 100. Maybe I'm wrong, but
looking into lib/util.c it seems this could be set differently
depending on system's configuration (or even kernel version).
So, probably this patch could sometimes work even for HZ < 1000,
but since it's your patch, I hope you do some additional checking
if it's always like this...
Cheers,
Jarek P.
next prev parent reply other threads:[~2007-12-20 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 3:31 [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly Satoru SATOH
2007-12-20 8:35 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-20 9:12 ` Jarek Poplawski
2007-12-20 16:21 ` Satoru SATOH
2007-12-20 20:24 ` Jarek Poplawski [this message]
2007-12-20 20:31 ` Jarek Poplawski
2007-12-21 2:24 ` Satoru SATOH
2007-12-21 8:34 ` Jarek Poplawski
2007-12-21 8:53 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-21 11:18 ` Bill Fink
2007-12-21 13:49 ` Satoru SATOH
2007-12-21 13:58 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-21 17:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476ACF8A.7060201@gmail.com \
--to=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=satoru.satoh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).