From: Oliver Hartkopp <oliver@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: sam@ravnborg.org, urs@isnogud.escape.de, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227
Date: Fri, 28 Dec 2007 09:58:15 +0100 [thread overview]
Message-ID: <4774BAA7.4040505@hartkopp.net> (raw)
In-Reply-To: <20071227.165052.167438890.davem@davemloft.net>
David Miller wrote:
> From: Oliver Hartkopp <oliver@hartkopp.net>
> Date: Thu, 27 Dec 2007 21:14:57 +0100
>
>
>> diff -uprN -X net-2.6.25/Documentation/dontdiff net-2.6.25/include/linux/can/bcm.h export/net2625-2007-12-27/include/linux/can/bcm.h
>> --- net-2.6.25/include/linux/can/bcm.h 2007-12-15 19:33:20.000000000 +0100
>> +++ export/net2625-2007-12-27/include/linux/can/bcm.h 2007-12-27 20:35:54.000000000 +0100
>>
>
> Also, please properly root your patches in the future:
>
> davem@sunset:~/src/GIT/net-2.6.25$ git apply --check --whitespace=error-all diff
> error: net2625-2007-12-27/include/linux/can/bcm.h: No such file or directory
>
>
I was just testing the patch with 'patch -p1 < ... ' but after your
error message i recognized why my patch was faulty as the paths had a
different root depth. Tnx for the hint. Such a mistake will not happen
again.
Thanks,
Oliver
prev parent reply other threads:[~2007-12-28 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 20:14 [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227 Oliver Hartkopp
2007-12-28 0:49 ` David Miller
2007-12-28 9:26 ` Oliver Hartkopp
2007-12-28 10:10 ` Oliver Hartkopp
2007-12-28 0:50 ` David Miller
2007-12-28 8:58 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4774BAA7.4040505@hartkopp.net \
--to=oliver@hartkopp.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).