From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774FCC31681 for ; Mon, 21 Jan 2019 18:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 492CC2089F for ; Mon, 21 Jan 2019 18:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LHE5SipL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbfAUShE (ORCPT ); Mon, 21 Jan 2019 13:37:04 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46781 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbfAUShD (ORCPT ); Mon, 21 Jan 2019 13:37:03 -0500 Received: by mail-wr1-f67.google.com with SMTP id l9so24503045wrt.13 for ; Mon, 21 Jan 2019 10:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4yOitQWSpxJgYIwMtLzzzSbBP15427BZkhe84dA2lkc=; b=LHE5SipLKP2Ghi7wIUBhvEKSEIAQESZmGXv8/Igz8UHmPoqagiooc+nfNMeg4JsoAb Px1CrPPbjprQEjeRdhWiHyReX8jrnooL+On7lZeNvdUSzs2xplXWs7aMNDHWXT/DMseC dQfrZIheAJ2Osp+qdE2JrULibKKK2j5wWVev1bhCg7fDuzGaro1laxDRhkRQ8e9zGruD AWWPHnbXWqxU9Vfd6fH944/WKkDLDidkWqDkT83Q6SwM2zP62AHC1fGg4AIdaPoEFAeE Yt/OlnX9lVslLnGSWynjg9sIay2/FutxdcpOFcTNDyvjjK1ln0PQJXyGpNLQFyiXn6mM n6Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4yOitQWSpxJgYIwMtLzzzSbBP15427BZkhe84dA2lkc=; b=fU1EU8xdGrRrFB96vz6z9OMibmjKMrEc2A1Pv0EypSVsMxsGhiZC4Rr+davCVv7U4V eiN9YgJYdQYeZ6/WSp9fjEwHciHFJlrhUJ57QAsTRWdeaayHYQ7NvE4nz3UnD6a/Q07p LTarGoFG/K0u1iz94kkB+AEMCrnrN/sm9JV+8b8GS795bBLxKLQZv1HzWtuzj0y+dWdR qU12tiU3bAWdW42ji5NXzQz/FJZbILNZf/V6dDDZtsrTAQWrBpFdAQpmM9iiI6AoDWDn uPOsSjMf5k9SFphGPA1Gkf2cF/F8n/eT/p4MgAupglsYZU2xfzOx45iqIpFoO9g3OQ9b F9Dg== X-Gm-Message-State: AJcUukc76BWFKb8favMg+fX8XQZBjMBp6SRh9lursP7ZL7UxDDKg1ou/ W91u/b/6w27eyhCZ7AkoxOCnzMK2 X-Google-Smtp-Source: ALg8bN4T0YyWCkXIqA1JJqWu9Dnr62o1tV/UCyl28g11EAh7Ih9kRbDC7O8Hse91zuq2Or3mzm8DSQ== X-Received: by 2002:adf:cc91:: with SMTP id p17mr29821546wrj.118.1548095821877; Mon, 21 Jan 2019 10:37:01 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:74ec:b48e:4f6b:21f4? (p200300EA8BF1E20074ECB48E4F6B21F4.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:74ec:b48e:4f6b:21f4]) by smtp.googlemail.com with ESMTPSA id b12sm26175069wmj.3.2019.01.21.10.37.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 10:37:01 -0800 (PST) Subject: Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <36a3f6a9-7f4c-7d51-05aa-71e847132102@gmail.com> <20190121163506.GE8620@lunn.ch> From: Heiner Kallweit Message-ID: <477939ff-14df-eca7-d652-0164ad6e5f41@gmail.com> Date: Mon, 21 Jan 2019 19:36:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190121163506.GE8620@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 21.01.2019 17:35, Andrew Lunn wrote: > On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: >> The state machine is a no-op before phy_start() has been called. >> Therefore let's enable it in phy_start() only. In phy_start() >> let's call phy_start_machine() instead of phy_trigger_machine(). >> phy_start_machine is an alias for phy_trigger_machine but it makes >> clearer that we start the state machine here instead of just >> triggering a run. > > Hi Heiner > > Documentation/networking/phy.txt has a section "Doing it all yourself" > It would be good to review that, and make sure that documentation is > still valid. I'm not sure any MAC driver actually does do it all > itself. So it might be worth reviewing the whole document and making > updates to remove parts of the text. > Right. I figured out that I have update phy.txt anyway because I recently removed phy_stop_interrupts which is referenced in the documentation. OK if we leave the patch series as is and I submit the documentation update as a separate patch? > Andrew > > Heiner