netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: [IPSEC] flow : NUMA aware hash table allocation
Date: Tue, 01 Jan 2008 13:44:15 +0100	[thread overview]
Message-ID: <477A359F.20902@cosmosbay.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Using __get_free_pages() has some drawbacks :

1) Not NUMA aware

2) 2^X page granularity :
On arches with big PAGE_SIZE, we waste some ram for each cpu.

(We currently use 1024 pointers, that is at most 8192 bytes, but
PAGE_SIZE can be 65536 for example : With say 64 possible cpus,
thats about 56*64 Kbytes that are wasted)

Using kmalloc_node() can help to solve these two points.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

  net/core/flow.c |   15 +++++----------
  1 files changed, 5 insertions(+), 10 deletions(-)


[-- Attachment #2: flow.patch --]
[-- Type: text/plain, Size: 886 bytes --]

diff --git a/net/core/flow.c b/net/core/flow.c
index a618f89..bcbbe2d 100644
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -311,18 +311,13 @@ void flow_cache_flush(void)
 static void __devinit flow_cache_cpu_prepare(int cpu)
 {
 	struct tasklet_struct *tasklet;
-	unsigned long order;
 
-	for (order = 0;
-	     (PAGE_SIZE << order) <
-		     (sizeof(struct flow_cache_entry *)*flow_hash_size);
-	     order++)
-		/* NOTHING */;
-
-	flow_table(cpu) = (struct flow_cache_entry **)
-		__get_free_pages(GFP_KERNEL|__GFP_ZERO, order);
+	flow_table(cpu) = kmalloc_node(
+		sizeof(struct flow_cache_entry *) * flow_hash_size,
+		GFP_KERNEL | __GFP_ZERO,
+		cpu_to_node(cpu));
 	if (!flow_table(cpu))
-		panic("NET: failed to allocate flow cache order %lu\n", order);
+		panic("NET: failed to allocate flow cache for cpu %d\n", cpu);
 
 	flow_hash_rnd_recalc(cpu) = 1;
 	flow_count(cpu) = 0;

             reply	other threads:[~2008-01-01 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 12:44 Eric Dumazet [this message]
2008-01-02  3:23 ` [IPSEC] flow : NUMA aware hash table allocation David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477A359F.20902@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).