From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 564D83D9DC7 for ; Fri, 3 Jul 2026 14:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783087967; cv=none; b=ZfNoMXL40nUGsJe0Vr3EMhAyl6YfzgmT9M09SWfq4YRyx+Yo3ocHT8T/2fKRNcx9mcbgAfqtYNDEqqSjm4SI/shBna4zlSGs9Rklsg7W6tbrgSjEsZM9YQ0Cr6NWFGxNihqnyOrIQxY1Rxlw82P9USgkjCjOjyU1lva1a1z8G/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783087967; c=relaxed/simple; bh=OAt/h6LcAZlSxDpYmMN2MII8fiusemJQ0zX2uNJgoGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SvPoZ5D2Ml6V6VNUiW7LDc9OTDFanxfzWLLtNWj/VpCGsUBoklthgG1LpPg/rbF9x6guoNzknN3JQhOssnz/jZb7t7hop6f8604dnYJ4IuSK2wgjsfActzTS5b1VBuHoLMr6qFJbfWLfTXGn//exM0bBRZVkk0qrPWoJcWg9QMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H2izTxoz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rFpAfVZA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H2izTxoz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rFpAfVZA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783087964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9NS1dD+VotgGOcfz0tQuHB8qQ2ds5u4lyfKoRXnWkYw=; b=H2izTxoztL2CzeBgT7mi4/csmxHk+Nl2U3sDsWKdx0Hm+ybFhFXqz/D+tisCi7z1RmfORz K+lvHC1GVQcIt9b92eaG7PGf0qk2bexk4Un9Sa9vpYmM/pPT2Fa0CMz+KjNMmurgsYfBbb IK0NOWISuZVI9hjoDpuwnIkA4lvvuns= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-z7DbiAcMOMKKmNZBM80JmA-1; Fri, 03 Jul 2026 10:12:43 -0400 X-MC-Unique: z7DbiAcMOMKKmNZBM80JmA-1 X-Mimecast-MFC-AGG-ID: z7DbiAcMOMKKmNZBM80JmA_1783087962 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4744b72f90bso497563f8f.0 for ; Fri, 03 Jul 2026 07:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783087962; x=1783692762; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9NS1dD+VotgGOcfz0tQuHB8qQ2ds5u4lyfKoRXnWkYw=; b=rFpAfVZApezdnfqYj1iw3A/pPTNhfA3xz2od/Nr39JGY9ccE/MvYOBM/4CYZshPYqt ASrOrxbbgaeRyi/W5v3mCTncSPgvFwl03LUZ3fUlnz4FdzzxsS4r0D7g3+7LcWVcavHC timvHcRXLe1MwlBYKo1NI8+id0rZttKxpp2UivShFhn2Vo9FXCP16ItMj8bgEu9bKNXq 1m1n0W4mLRxnNF/foEZdwH1s4+Vt2vgonGcPXdPBOqZuUdiKjJgFbdZV4rB6TIeGP2ZG 2OaTa8VDS3EGlkjniPut3PawjOUyq1E6kUGD3FHnxVWI5FCMZg6HPQddJkPX2dbDjUNp hLyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783087962; x=1783692762; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9NS1dD+VotgGOcfz0tQuHB8qQ2ds5u4lyfKoRXnWkYw=; b=sWDYAnZgZ+1KOFAsTOlie8R+FhegZFbkyGwSFXPtXoi5KUWYl1KMg1pomnUFZnsaLN ZQiN4Y1ieb8x2DmSUUWSuHDCd2c66DUWFuyWt54MsE2ww8ofxd3MdEctY7T+O/h2LHqd bZ7q7nSg2xalr+IfJtpmY+4yRytBBLA0l/Nc3J2SrGz1iCsYnNoAQhQcNI5NhSMHU/Ks YhmKfqpoQP6I3P/6B7uFu7pjWxLHJwI9PqZOk9nY7Wy8tW36cATY6gZr/Myd3GNHZWaX Y7jaw3iAqkfqVcsGnu+ril3QnNRFQ9qcc9rWdptFM9UsA2M96IjiGWcSOgySm3avfmiD /ubA== X-Forwarded-Encrypted: i=1; AFNElJ9XG8JaeF6clrhGPsuUJJdE5ZWE/e3OLES64BLGAW4stzWHQ0n47UDf6BAQmOeyTL4ZiZx2GoM=@vger.kernel.org X-Gm-Message-State: AOJu0YwJFhXze92QQPA6fJXPTmUw6Fv80LuMO8hL1atz7MRhPDrFKbN0 nIX1aByVsLDsXalJtNTakQnlgHvaR3xazS/EwipjD602rauQYmUSId9f9OTjOCx6vOVLAa/4ncB /3wJL2BNhXZIZGf+vf8eICVaWKsHw0vZp7iyA4h7iKafDhkVpsF2+bb0R+A== X-Gm-Gg: AfdE7cm26ykes861ZYzyjph8anJ2POS+I7R/fbl4jF9FKH5507PwveDvWnHmQkkTjFy ZJBN1206bSU2OWfK4BxPRMhU7GQYBI+jTz0vD6kR96WfKh/AI2KzU3Qb67ZsUG/E9vInSYtTDBO u41bGlyAsE50P0Rag3eHUnmCIBY1jiUcmlYk54zS14BLoOhTxBiLMNXElzZ4OylAXNyPBH+lIAr PPQiCYA/ZLgWKFEutMen9jTqcjS4gVEFlqaPCuRVdPgS3BgCSE4xUw956kWhtA11GQ8PhBww3hs 1Krpl5FKF+hKhIf1nz3aqMfj1U/ThOYAZqQsybLaeeMEGShmpQLrOXx6GqpWAEuTcNahY2T7je7 TlvOj8I1lwwEZcZ9O7EgBv+kiZS29cH5saSOW69Jbwtn0cGI2Lrgzq8GccWtuGEc4PMyekAvupE 0skN43xOFv6A== X-Received: by 2002:a05:600c:5808:b0:492:4911:8a with SMTP id 5b1f17b1804b1-493d0f10382mr456135e9.12.1783087961921; Fri, 03 Jul 2026 07:12:41 -0700 (PDT) X-Received: by 2002:a05:600c:5808:b0:492:4911:8a with SMTP id 5b1f17b1804b1-493d0f10382mr455835e9.12.1783087961477; Fri, 03 Jul 2026 07:12:41 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef17c82sm141919575e9.1.2026.07.03.07.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 07:12:40 -0700 (PDT) Message-ID: <477e46ec-24b1-4d3f-bbe7-347df18d5148@redhat.com> Date: Fri, 3 Jul 2026 16:12:39 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] bnx2x: fix null pointer dereference in bnx2x_free_mem_bp() To: Abdun Nihaal , skalluru@marvell.com Cc: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, stable@vger.kernel.org References: <20260701065030.381836-1-nihaal@cse.iitm.ac.in> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260701065030.381836-1-nihaal@cse.iitm.ac.in> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/1/26 8:50 AM, Abdun Nihaal wrote: > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > index 5b2640bd31c3..25ee45cb7f3f 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > @@ -4712,8 +4712,9 @@ void bnx2x_free_mem_bp(struct bnx2x *bp) > { > int i; > > - for (i = 0; i < bp->fp_array_size; i++) > - kfree(bp->fp[i].tpa_info); > + if (bp->fp) > + for (i = 0; i < bp->fp_array_size; i++) > + kfree(bp->fp[i].tpa_info); I think that a cleaner fix would be moving bp->fp_array_size initialization after bp->fp. /P