From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [XFRM]: xfrm_algo_clone() allocates too much memory
Date: Wed, 09 Jan 2008 08:51:39 +0100 [thread overview]
Message-ID: <47847D0B.3050003@cosmosbay.com> (raw)
In-Reply-To: <20080108.234012.181072357.davem@davemloft.net>
David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Wed, 09 Jan 2008 08:29:11 +0100
>
> Thanks for catching this.
>
> Applied to net-2.6
>
>> +static inline int xfrm_alg_len(struct xfrm_algo *alg)
>> +{
>> + return sizeof(*alg) + ((alg->alg_key_len + 7) / 8);
>> +}
>
> That gets emitted as a divide doesn't it :-))))
>
>
Yes I have a patch for these divides, but will apply on 2.6.25 once this one
hits it. (this saves 192 bytes of kernel text BTW)
next prev parent reply other threads:[~2008-01-09 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 18:37 [XFRM]: xfrm_algo_clone() allocates too much memory Eric Dumazet
2008-01-09 6:15 ` Herbert Xu
2008-01-09 7:29 ` Eric Dumazet
2008-01-09 7:40 ` David Miller
2008-01-09 7:51 ` Eric Dumazet [this message]
2008-01-09 7:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47847D0B.3050003@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).