make ipv6_sysctl_register to return a value

make ipv6_sysctl_register to return a value

[Daniel Lezcano]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: ipv6-sysctl-register-return-value.patch --]
[-- Type: text/x-patch, Size: 2093 bytes --]

Subject: make ipv6_sysctl_register to return a value
From: Daniel Lezcano <dlezcano@fr.ibm.com>

This patch makes the function ipv6_sysctl_register to return a
value. The af_inet6 init function is now able to handle an error
and catch it from the initialization of the sysctl.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
 include/net/ipv6.h         |    2 +-
 net/ipv6/af_inet6.c        |    5 ++++-
 net/ipv6/sysctl_net_ipv6.c |    6 +++++-
 3 files changed, 10 insertions(+), 3 deletions(-)

Index: net-2.6.25/include/net/ipv6.h
===================================================================
--- net-2.6.25.orig/include/net/ipv6.h
+++ net-2.6.25/include/net/ipv6.h
@@ -620,7 +620,7 @@ static inline int snmp6_unregister_dev(s
 extern ctl_table ipv6_route_table[];
 extern ctl_table ipv6_icmp_table[];
 
-extern void ipv6_sysctl_register(void);
+extern int ipv6_sysctl_register(void);
 extern void ipv6_sysctl_unregister(void);
 #endif
 
Index: net-2.6.25/net/ipv6/af_inet6.c
===================================================================
--- net-2.6.25.orig/net/ipv6/af_inet6.c
+++ net-2.6.25/net/ipv6/af_inet6.c
@@ -783,7 +783,9 @@ static int __init inet6_init(void)
 	 */
 
 #ifdef CONFIG_SYSCTL
-	ipv6_sysctl_register();
+	err = ipv6_sysctl_register();
+	if (err)
+		goto sysctl_fail;
 #endif
 	err = icmpv6_init(&inet6_family_ops);
 	if (err)
@@ -897,6 +899,7 @@ ndisc_fail:
 icmp_fail:
 #ifdef CONFIG_SYSCTL
 	ipv6_sysctl_unregister();
+sysctl_fail:
 #endif
 	cleanup_ipv6_mibs();
 out_unregister_sock:
Index: net-2.6.25/net/ipv6/sysctl_net_ipv6.c
===================================================================
--- net-2.6.25.orig/net/ipv6/sysctl_net_ipv6.c
+++ net-2.6.25/net/ipv6/sysctl_net_ipv6.c
@@ -90,9 +90,13 @@ static struct ctl_path ipv6_ctl_path[] =
 
 static struct ctl_table_header *ipv6_sysctl_header;
 
-void ipv6_sysctl_register(void)
+int ipv6_sysctl_register(void)
 {
 	ipv6_sysctl_header = register_sysctl_paths(ipv6_ctl_path, ipv6_table);
+	if (!ipv6_sysctl_header)
+		return -ENOMEM;
+
+	return 0;
 }
 
 void ipv6_sysctl_unregister(void)

Re: make ipv6_sysctl_register to return a value

[David Miller]

Why did you post this again?  It's identical to patch 1/9
from the previous series you sent out.

This is confusing, since it makes me think you wanted me to
perhaps do something different or update an already
submitted patch.

Re: make ipv6_sysctl_register to return a value

[Daniel Lezcano]

David Miller wrote:
> Why did you post this again?  It's identical to patch 1/9
> from the previous series you sent out.
> 
> This is confusing, since it makes me think you wanted me to
> perhaps do something different or update an already
> submitted patch.

I thought you was expecting a new netns ipv6 sysctl series and ignored 
the current one. While I was looking at them again I found a problem and 
I wanted to fix that before resending. In the meantime, there were three 
independant trivial patches I wanted to send as a pre-requesite for the 
incoming sysctl patches. Bad idea ... :)

  - make ipv6_sysctl_register to return a value
  - make a subsystem for af_inet6
  - add ipv6 structure for netns

With the sysctl Pavel's patch, the first one does not apply.

To clear out any confusion, please can you just ignore all my previous 
patches, I will resend a new serie rebased on the work done by Pavel.

Sorry for the inconvenience.

Thanks.

   -- Daniel

Re: make ipv6_sysctl_register to return a value

[David Miller]

From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Wed, 09 Jan 2008 10:56:48 +0100

> To clear out any confusion, please can you just ignore all my previous 
> patches, I will resend a new serie rebased on the work done by Pavel.

Ok, thanks.