* [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for.
@ 2008-01-10 15:05 Pavel Emelyanov
2008-01-11 6:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2008-01-10 15:05 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List, Alexey Kuznetsov, devel
When I studied the neighbor code I puzzled over what
the NUD can mean for quite a long time.
Finally I asked Alexey and he said that this was smth
like "neighbor unreachability detection".
Does it worth adding a comment helping future developers
understand what's going on?
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/include/net/neighbour.h b/include/net/neighbour.h
index 09f9fc6..bc34144 100644
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -26,6 +26,10 @@
#include <linux/sysctl.h>
#include <net/rtnetlink.h>
+/*
+ * NUD stands for "neighbor unreachability detection"
+ */
+
#define NUD_IN_TIMER (NUD_INCOMPLETE|NUD_REACHABLE|NUD_DELAY|NUD_PROBE)
#define NUD_VALID (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE|NUD_PROBE|NUD_STALE|NUD_DELAY)
#define NUD_CONNECTED (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for.
2008-01-10 15:05 [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for Pavel Emelyanov
@ 2008-01-11 6:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-11 6:37 UTC (permalink / raw)
To: xemul; +Cc: netdev, kuznet, devel
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 10 Jan 2008 18:05:25 +0300
> When I studied the neighbor code I puzzled over what
> the NUD can mean for quite a long time.
>
> Finally I asked Alexey and he said that this was smth
> like "neighbor unreachability detection".
>
> Does it worth adding a comment helping future developers
> understand what's going on?
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
NUD is a common acronym in the IPV6 RFCs and various books
on the topic, but it doesn't hurt to add this comment so I
applied this patch thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-11 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-10 15:05 [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for Pavel Emelyanov
2008-01-11 6:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).