From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: NetDev <netdev@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)
Date: Thu, 10 Jan 2008 16:22:08 -0800 [thread overview]
Message-ID: <4786B6B0.5050105@intel.com> (raw)
In-Reply-To: <4786B1E7.5030700@pobox.com>
Jeff Garzik wrote:
> Kok, Auke wrote:
>> All,
>>
>> here is the third version of the igb (82575) ethernet controller
>> driver. This
>> driver was previously posted 2007-07-13 and 2007-12-11. Many comments
>> received
>> were addressed:
>>
>> - removed indirection wrappers in the same way as e1000e and ixgbe.
>> - cleaned up largely against sparse, checkpatch
>> - removed module parameters and moved functionality to ethtool ioctls
>> - new NAPI API rewrites
>> - by default the driver runs in multiqueue mode with 2 to 40 RX queues
>> enabled.
>>
>> and specifically in this version:
>>
>> - register macro's were condensed for readability
>> - fixed namespace collisions by renaming functions to igb_*
>>
>> Since the driver is still too large (allthough the patch shrunk from
>> 558k to 416k
>> to 407k, almost 38% of its size) to post to this list I am attaching
>> the bzipped
>> patch here. You can get the same driver alternatively from here:
>>
>> http://foo-projects.org/~sofar/0001-igb-PCI-Express-82575-Gigabit-Ethernet-driver.patch
>>
>> [407k]
>> http://foo-projects.org/~sofar/0001-igb-PCI-Express-82575-Gigabit-Ethernet-driver.patch.bz2
>>
>> [74k]
>>
>> or through git:
>> git://lost.foo-projects.org/~ahkok/git/linux-2.6 #igb
>>
>>
>> There are several concerns still open for this driver:
>> - hardware code is still a large API. we're expecting more hardware to be
>> supported by this driver in the future. The API has already been
>> scrubbed but we
>> anticipate that the remaining hooks will be used in the future.
>> - The register defines are still named "E1000_" as they are mostly
>> identical to
>> the e1000 chipsets (igb register space is a superset of most recent
>> e1000 register
>> sets).
>
> I think we can throw it into netdev#upstream if you're ready...
yes, of course :)
both the patch file and the git tree should work for you.
Cheers,
Auke
next prev parent reply other threads:[~2008-01-11 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 23:32 RFC: igb: Intel 82575 gigabit ethernet driver (take #3) Kok, Auke
2008-01-11 0:01 ` Jeff Garzik
2008-01-11 0:22 ` Kok, Auke [this message]
2008-01-11 9:17 ` Christoph Hellwig
2008-01-22 10:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4786B6B0.5050105@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).