netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat
Date: Sat, 12 Jan 2008 20:03:31 +0100	[thread overview]
Message-ID: <47890F03.5080503@trash.net> (raw)
In-Reply-To: <20080112.032318.201654370.davem@davemloft.net>

David Miller wrote:
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Sat, 12 Jan 2008 11:34:27 +0200
> 
> Ilpo, please post netfilter patches to netfilter-devel,
> CC:'ing Patrick McHardy.
> 
> Patrick, please review, thanks.

This looks fine to me, thanks Ilpo.

>> net/netfilter/xt_policy.c:
>>   policy_mt | -906
>>  1 function changed, 906 bytes removed, diff: -906
>>
>> net/netfilter/xt_policy.c:
>>   match_xfrm_state | +427
>>  1 function changed, 427 bytes added, diff: +427
>>
>> net/netfilter/xt_policy.o:
>>  2 functions changed, 427 bytes added, 906 bytes removed, diff: -479
>>
>> Alternatively, this could be done by combining identical
>> parts of the match_policy_in/out()

That would probably end up rather ugly because they walk
over different structures and have some minor differences.

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-01-12 19:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-12  9:34 [PATCH net-2.6.25 0/8] [NET]: More uninlining & related Ilpo Järvinen
2008-01-12 11:16 ` David Miller
     [not found] ` <12001304691978-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:18   ` [PATCH 1/8] [TCP]: Uninline tcp_set_state David Miller
     [not found]   ` <1200130469783-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:19     ` [PATCH 2/8] [TCP]: Uninline tcp_is_cwnd_limited David Miller
     [not found]     ` <12001304693917-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:20       ` [PATCH 3/8] [XFRM] xfrm_policy: kill some bloat David Miller
     [not found]       ` <12001304703362-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:21         ` [PATCH 4/8] [IPV6] route: " David Miller
     [not found]         ` <12001304703302-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:22           ` [PATCH 5/8] [NETLINK] af_netlink: " David Miller
     [not found]           ` <12001304703789-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:23             ` [PATCH 6/8] [NETFILTER] xt_policy.c: " David Miller
2008-01-12 19:03               ` Patrick McHardy [this message]
2008-01-13  5:26                 ` David Miller
     [not found]             ` <12001304701053-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:24               ` [PATCH 7/8] [PKTGEN]: Kill dead static inlines David Miller
     [not found]               ` <12001304701901-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:25                 ` [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs David Miller
  -- strict thread matches above, loose matches on Subject: below --
2008-01-12  9:40 [PATCH net-2.6.25 0/8] [NET]: More uninlining & related Ilpo Järvinen
2008-01-12  9:40 ` [PATCH 1/8] [TCP]: Uninline tcp_set_state Ilpo Järvinen
2008-01-12  9:40   ` [PATCH 2/8] [TCP]: Uninline tcp_is_cwnd_limited Ilpo Järvinen
2008-01-12  9:40     ` [PATCH 3/8] [XFRM] xfrm_policy: kill some bloat Ilpo Järvinen
2008-01-12  9:40       ` [PATCH 4/8] [IPV6] route: " Ilpo Järvinen
2008-01-12  9:40         ` [PATCH 5/8] [NETLINK] af_netlink: " Ilpo Järvinen
2008-01-12  9:40           ` [PATCH 6/8] [NETFILTER] xt_policy.c: " Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47890F03.5080503@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).