Re: [PATCH 2/4] [ROSE] rose_get_route() template

[Eric Dumazet <dada1@cosmosbay.com>]

Bernard Pidoux a écrit :
>  From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001
> From: Bernard Pidoux <f6bvp@amsat.org>
> Date: Thu, 10 Jan 2008 23:01:46 +0100
> Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route()
> 
> Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
> ---
>  include/net/rose.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/rose.h b/include/net/rose.h
> index e5bb084..d3ab453 100644
> --- a/include/net/rose.h
> +++ b/include/net/rose.h
> @@ -202,6 +202,7 @@ extern struct net_device *rose_dev_first(void);
>  extern struct net_device *rose_dev_get(rose_address *);
>  extern struct rose_route *rose_route_free_lci(unsigned int, struct 
> rose_neigh *);
>  extern struct rose_neigh *rose_get_neigh(rose_address *, unsigned char 
> *, unsigned char *);
> +extern struct rose_neigh *rose_get_route(rose_address *, unsigned char 
> *, unsigned char *);
>  extern int  rose_rt_ioctl(unsigned int, void __user *);
>  extern void rose_link_failed(ax25_cb *, int);
>  extern int  rose_route_frame(struct sk_buff *, ax25_cb *);
> -- 

Strange... if rose_get_route() is used only in net/rose/rose_route.c, why dont 
you define it static, and not extern in include/net/rose.h ?