From: Jeff Garzik <jgarzik@pobox.com>
To: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB
Date: Sat, 12 Jan 2008 17:27:12 -0500 [thread overview]
Message-ID: <47893EC0.1080303@pobox.com> (raw)
In-Reply-To: <110604.81450.qm@web52011.mail.re2.yahoo.com>
Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Add a guideline for hard_start_xmit method not to
> modify SKB.
>
> Signed-off-by: Matti Linnanvuori
> <mattilinnanvuori@yahoo.com>
>
> ---
>
>
> --- a/Documentation/networking/driver.txt 2007-12-22
> 18:50:28.062169500 +0200
> +++ b/Documentation/networking/driver.txt 2007-12-22
> 19:10:58.726566000 +0200
>
> @@ -74,6 +74,9 @@ Transmit path guidelines:
> If you return 1 from the hard_start_xmit method,
> you must not keep
> any reference to that SKB and you must not attempt
> to free it up.
>
> +4) A hard_start_xmit method must not modify the
> cloned parts of the
> + SKB.
> +
> Probing guidelines:
>
> 1) Any hardware layer address you obtain for your
> device should
>
patch is word-wrapped
prev parent reply other threads:[~2008-01-12 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 17:22 [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB Matti Linnanvuori
2008-01-12 22:27 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47893EC0.1080303@pobox.com \
--to=jgarzik@pobox.com \
--cc=mattilinnanvuori@yahoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).