* [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB
@ 2007-12-22 17:22 Matti Linnanvuori
2008-01-12 22:27 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Matti Linnanvuori @ 2007-12-22 17:22 UTC (permalink / raw)
To: jgarzik, netdev
From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Add a guideline for hard_start_xmit method not to
modify SKB.
Signed-off-by: Matti Linnanvuori
<mattilinnanvuori@yahoo.com>
---
--- a/Documentation/networking/driver.txt 2007-12-22
18:50:28.062169500 +0200
+++ b/Documentation/networking/driver.txt 2007-12-22
19:10:58.726566000 +0200
@@ -74,6 +74,9 @@ Transmit path guidelines:
If you return 1 from the hard_start_xmit method,
you must not keep
any reference to that SKB and you must not attempt
to free it up.
+4) A hard_start_xmit method must not modify the
cloned parts of the
+ SKB.
+
Probing guidelines:
1) Any hardware layer address you obtain for your
device should
Machen Sie Yahoo! zu Ihrer Startseite. Los geht's:
http://de.yahoo.com/set
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB
2007-12-22 17:22 [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB Matti Linnanvuori
@ 2008-01-12 22:27 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-01-12 22:27 UTC (permalink / raw)
To: Matti Linnanvuori; +Cc: netdev
Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Add a guideline for hard_start_xmit method not to
> modify SKB.
>
> Signed-off-by: Matti Linnanvuori
> <mattilinnanvuori@yahoo.com>
>
> ---
>
>
> --- a/Documentation/networking/driver.txt 2007-12-22
> 18:50:28.062169500 +0200
> +++ b/Documentation/networking/driver.txt 2007-12-22
> 19:10:58.726566000 +0200
>
> @@ -74,6 +74,9 @@ Transmit path guidelines:
> If you return 1 from the hard_start_xmit method,
> you must not keep
> any reference to that SKB and you must not attempt
> to free it up.
>
> +4) A hard_start_xmit method must not modify the
> cloned parts of the
> + SKB.
> +
> Probing guidelines:
>
> 1) Any hardware layer address you obtain for your
> device should
>
patch is word-wrapped
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-12 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-22 17:22 [PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB Matti Linnanvuori
2008-01-12 22:27 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).