* [FIB]: removes a memset() call in tnode_new()
@ 2008-01-13 7:35 Eric Dumazet
2008-01-13 8:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2008-01-13 7:35 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
tnode_alloc() already clears allocated memory, using kcalloc()
or alloc_pages(GFP_KERNEL|__GFP_ZERO, ...)
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: fib_trie.patch --]
[-- Type: text/plain, Size: 355 bytes --]
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index a418498..f26ba31 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -391,7 +391,6 @@ static struct tnode* tnode_new(t_key key, int pos, int bits)
struct tnode *tn = tnode_alloc(sz);
if (tn) {
- memset(tn, 0, sz);
tn->parent = T_TNODE;
tn->pos = pos;
tn->bits = bits;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [FIB]: removes a memset() call in tnode_new()
2008-01-13 7:35 [FIB]: removes a memset() call in tnode_new() Eric Dumazet
@ 2008-01-13 8:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-13 8:43 UTC (permalink / raw)
To: dada1; +Cc: netdev
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sun, 13 Jan 2008 08:35:07 +0100
> tnode_alloc() already clears allocated memory, using kcalloc()
> or alloc_pages(GFP_KERNEL|__GFP_ZERO, ...)
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-13 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-13 7:35 [FIB]: removes a memset() call in tnode_new() Eric Dumazet
2008-01-13 8:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).