From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
m.kozlowski@tuxland.pl, davem@davemloft.net,
sparclinux@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sparc oops in ip_fast_csum
Date: Mon, 14 Jan 2008 07:09:22 +0100 [thread overview]
Message-ID: <478AFC92.50508@trash.net> (raw)
In-Reply-To: <20080106041430.GA3784@gondor.apana.org.au>
Herbert Xu wrote:
> Patrick, please have a look at the former. In fact it's not just
> that ihl may be bogus (which might be harmless as long as the REJECT
> hook only gets called from within the IP stack), I think REJECT would
> also do the wrong thing if the packet had IP options. So perhaps we
> should just make it create a packet from scratch rather than being
> too clever in reusing the old one.
We currently silently drop packets with IP options in the reject
target. The length check should be fine since its only called
through the IP stack or bridge netfilter, which replicates the
IP stack checks.
But I agree to your suggestion, that will allow us to properly
handle packets with IP options. I'll take care of this.
next prev parent reply other threads:[~2008-01-14 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 17:37 sparc oops in ip_fast_csum Mariusz Kozlowski
2008-01-05 9:44 ` Al Viro
2008-01-06 0:22 ` Herbert Xu
2008-01-06 0:57 ` Jan Engelhardt
2008-01-06 1:03 ` Herbert Xu
2008-01-06 2:02 ` Al Viro
2008-01-06 4:14 ` Herbert Xu
2008-01-14 6:09 ` Patrick McHardy [this message]
2008-01-14 6:19 ` David Miller
2008-01-06 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478AFC92.50508@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).