From: Dzianis Kahanovich <mahatma@bspu.unibel.by>
To: netdev@vger.kernel.org
Cc: hadi@cyberus.ca, mahatma@eu.by
Subject: Re: [PATCH 2.6.23+] ingress classify to [nf]mark
Date: Mon, 14 Jan 2008 13:40:00 -0200 [thread overview]
Message-ID: <478B8250.90602@bspu.unibel.by> (raw)
In-Reply-To: <1200253484.4427.33.camel@localhost>
jamal wrote:
>> I in doubts only about "action continue".
>> To "and/or" behaviour one of best usage are (example):
>
> I dont think you should be touching the action part at all primarily
> because actions can set the mark after classification.
Yes, I only do it by inertia after "#define tc_index mark".
I not understand why "tc_index" changed in this place. 1) there are ingress 2)
there are "OK" action. Are "tc_index" will not changed after: "tc filter add
dev eth0 parent ffff: ... flowid 1:1 action continue" ? In general - are
tc_index useful in ingress? (may be tc_index used in [nf]mark-style, but even
in netfilter it feature migrate - IMHO, may be I time to time do not see in
needed place)
Sorry, I just change focus from existing "tc_index=..." to common behaviour ;)
[...]
> Please refer to what i said above; if what i said still doesnt make
> sense i can create (the simple) patch.
A bit vague... sorry...
--
WBR,
Denis Kaganovich, mahatma@eu.by http://mahatma.bspu.unibel.by
next prev parent reply other threads:[~2008-01-14 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 19:05 [PATCH 2.6.23+] ingress classify to [nf]mark Dzianis Kahanovich
2008-01-10 17:29 ` Patrick McHardy
2008-01-11 17:37 ` Dzianis Kahanovich
2008-01-10 21:39 ` jamal
2008-01-11 17:24 ` Dzianis Kahanovich
2008-01-11 14:59 ` jamal
2008-01-11 20:42 ` Dzianis Kahanovich
2008-01-12 3:03 ` jamal
2008-01-12 17:56 ` Dzianis Kahanovich
2008-01-13 19:44 ` jamal
2008-01-14 15:40 ` Dzianis Kahanovich [this message]
2008-01-14 12:56 ` jamal
2008-01-14 22:20 ` Dzianis Kahanovich
2008-01-16 12:45 ` jamal
2008-01-23 0:14 ` Dzianis Kahanovich
2008-01-23 16:42 ` Dzianis Kahanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478B8250.90602@bspu.unibel.by \
--to=mahatma@bspu.unibel.by \
--cc=hadi@cyberus.ca \
--cc=mahatma@eu.by \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).