netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Badalian Vyacheslav <slavon@bigtelecom.ru>, netdev@vger.kernel.org
Subject: Re: Packetlost when "tc qdisc del dev eth0 root"
Date: Wed, 16 Jan 2008 09:05:47 +0100	[thread overview]
Message-ID: <478DBADB.1080200@trash.net> (raw)
In-Reply-To: <20080116080259.GB1638@ff.dom.local>

Jarek Poplawski wrote:
> On Wed, Jan 16, 2008 at 06:02:00AM +0100, Patrick McHardy wrote:
> ...
>> This would need support from the qdiscs to do it properly. Looks
>> non-trivial for HTB/HFSC/CBQ, but the others shouldn't be that hard.
> 
> Yes. At first I've thought this would need quite a lot of work, but
> it seems, there could be probably used something very simple too,
> like e.g. a 'dummy' sched switcher, which after replacing as a root
> the old qdisc and knowing the pointer to the new one could simply
> call for dequeing the old one and the new one for everything else.
> Then, after completely dequeuing it would call destroy for the old
> qdisc and probably switch itself with the new one as a root. If this
> new one were created temporarily e.g. on a dummyX dev, and the switch
> qdisc added to dummyY (as a temporary holder) with ethX and dummyX as
> parameters, it seems this could be done without any API changes.
> (But, of course, something more sophisticated should be even better.)


Yes, thats one possibility (without the dummy device though please).
But I wonder what this would actually be useful for. I don't think
replacing the root qdisc by a different type is a common scenario,
for the same type you can simply use "tc qdisc change", "tc class
change" and "tc class replace".

Badalian, what are you actually doing?

  reply	other threads:[~2008-01-16  8:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 11:10 Packetlost when "tc qdisc del dev eth0 root" Badalian Vyacheslav
2008-01-15 16:05 ` Patrick McHardy
2008-01-15 16:11   ` slavon
2008-01-15 21:15   ` Jarek Poplawski
2008-01-15 21:46     ` slavon
2008-01-15 22:04       ` slavon
2008-01-15 22:49         ` Jarek Poplawski
2008-01-16  5:12         ` Patrick McHardy
2008-01-19 23:21           ` Jarek Poplawski
2008-01-15 22:32       ` Jarek Poplawski
2008-01-15 23:16       ` Glen Turner
2008-01-16  5:02     ` Patrick McHardy
2008-01-16  8:02       ` Jarek Poplawski
2008-01-16  8:05         ` Patrick McHardy [this message]
2008-01-16  8:35           ` Badalian Vyacheslav
2008-01-16  9:42             ` Jarek Poplawski
2008-01-16  8:52           ` Jarek Poplawski
2008-01-16  8:54             ` Badalian Vyacheslav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478DBADB.1080200@trash.net \
    --to=kaber@trash.net \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=slavon@bigtelecom.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).